[web-animations-1] Update the procedure for determining if the animation play state is idle. #5409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flackr
reviewed
Sep 2, 2021
|
I thought we concluded in #5400 that we should not do this? |
|
Abandoning the PR based on #5400. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5400
Explicitly setting the start time on an animation with a null timeline causes it to be flagged as being in the running state. The constraint that the start time be unresolved was added recently to accommodate scroll-timelines, which may have an unresolved current time even though the start time has been set. Relaxing the constraint to required that the start time be unresolved or the timeline be null restores the previous behavior for null timelines without breaking scroll timelines.