Skip to content

[web-animations-1] Add hold phase to animation #4325 #5479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[web-animations-1] Add hold phase to animation #4325 #5479

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5581f2d
Added hold phase calculations to all places where hold time is also u…
Aug 26, 2020
01e9af7
Added conditions to the animation effect phase calculation to account…
Aug 26, 2020
f183cfe
Reworded explanation of current phase, reworded setting hold phase fr…
Sep 10, 2020
6885c21
Fixed a few spacing, punctuation, and grammar issues.
Sep 11, 2020
fad6e37
Adding back in condition for current phase that is needed when animat…
Sep 15, 2020
1ca8964
Moved changes to Web-Animations-2 from Web-Animations-1
Jan 5, 2021
d4d46a6
Fixed typo
Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added conditions to the animation effect phase calculation to account… 
… for animation current phase.
  • Loading branch information
Jordan Taylor committed Jan 4, 2021
commit 01e9af7e8550505eb0c0b507f0855d61ced62739
12 changes: 10 additions & 2 deletions web-animations-1/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2401,19 +2401,27 @@ definitions:

An <a>animation effect</a> is in the <dfn>before phase</dfn> if the
animation effect's <a>local time</a> is not <a>unresolved</a> and
<em>either</em> of the following conditions are met:
<em>any</em> of the following conditions are met:

1. the <a>local time</a> is less than the <a>before-active boundary time</a>,
<em>or</em>
1. the effect is <a>associated with an animation</a> <em>and</em> the
associated <a>animation</a>'s <a>current phase</a> is
[=timeline before phase|before=] <em>and</em> the <a>local time</a> is equal
the <a>before-active boundary time</a>, <em>or</em>
1. the <a>animation direction</a> is &lsquo;backwards&rsquo; and the <a>local
time</a> is equal to the <a>before-active boundary time</a>.

An <a>animation effect</a> is in the <dfn>after phase</dfn> if the
animation effect's <a>local time</a> is not <a>unresolved</a> and
<em>either</em> of the following conditions are met:
<em>any</em> of the following conditions are met:

1. the <a>local time</a> is greater than the <a>active-after boundary
time</a>, <em>or</em>
1. the effect is <a>associated with an animation</a> <em>and</em> the
associated <a>animation</a>'s <a>current phase</a> is
[=timeline after phase|after=] <em>and</em> the <a>local time</a> is equal
to the <a>active-after boundary time</a>, <em>or</em>
1. the <a>animation direction</a> is &lsquo;forwards&rsquo; and the <a>local
time</a> is equal to the <a>active-after boundary time</a>.

Expand Down