Skip to content

[css-color-adjust-1] Move color-scheme meta to HTML #3846 #5540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

lilles
Copy link
Member

@lilles lilles commented Sep 23, 2020

Per resolution: #3846 (comment).

Add a reference to the HTML specification from the specification of the color-scheme property.

HTML pull request: whatwg/html#5938

Per resolution in issue w3c#3846. Add a reference to the HTML specification
from the specification of the color-scheme property.

HTML pull request: whatwg/html#5938
Copy link
Collaborator

@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a Note, since the normative definition is in HTML, right?
Also, please move it below the note about what light and dark mean.
Otherwise seems fine.

@lilles lilles requested a review from fantasai September 24, 2020 07:14
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 24, 2020
Per CSSWG resolution[1]. Also move the tests to wpt/html since the spec
is moving there per the same resolution.

Relevant spec pull requests are [2][3].

[1] w3c/csswg-drafts#3846 (comment)
[2] whatwg/html#5938
[3] w3c/csswg-drafts#5540

Bug: 1103669
Change-Id: I553c5ca8c1223cd746dc05471eb6d3c5d9d5f19b
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 24, 2020
Per CSSWG resolution[1]. Also move the tests to wpt/html since the spec
is moving there per the same resolution.

Relevant spec pull requests are [2][3].

[1] w3c/csswg-drafts#3846 (comment)
[2] whatwg/html#5938
[3] w3c/csswg-drafts#5540

Bug: 1103669
Change-Id: I553c5ca8c1223cd746dc05471eb6d3c5d9d5f19b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380654
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810183}
blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this pull request Sep 24, 2020
Per CSSWG resolution[1]. Also move the tests to wpt/html since the spec
is moving there per the same resolution.

Relevant spec pull requests are [2][3].

[1] w3c/csswg-drafts#3846 (comment)
[2] whatwg/html#5938
[3] w3c/csswg-drafts#5540

Bug: 1103669
Change-Id: I553c5ca8c1223cd746dc05471eb6d3c5d9d5f19b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380654
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810183}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 24, 2020
Per CSSWG resolution[1]. Also move the tests to wpt/html since the spec
is moving there per the same resolution.

Relevant spec pull requests are [2][3].

[1] w3c/csswg-drafts#3846 (comment)
[2] whatwg/html#5938
[3] w3c/csswg-drafts#5540

Bug: 1103669
Change-Id: I553c5ca8c1223cd746dc05471eb6d3c5d9d5f19b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380654
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810183}
@tabatkins tabatkins merged commit 4dacf26 into w3c:master Sep 24, 2020
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 26, 2020
…=testonly

Automatic update from web-platform-tests
Meta color-scheme is allowed in body.

Per CSSWG resolution[1]. Also move the tests to wpt/html since the spec
is moving there per the same resolution.

Relevant spec pull requests are [2][3].

[1] w3c/csswg-drafts#3846 (comment)
[2] whatwg/html#5938
[3] w3c/csswg-drafts#5540

Bug: 1103669
Change-Id: I553c5ca8c1223cd746dc05471eb6d3c5d9d5f19b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380654
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810183}

--

wpt-commits: a3921bb66b03e89253c7a9b6f84bd37990cfe0b9
wpt-pr: 25756
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Sep 28, 2020
…=testonly

Automatic update from web-platform-tests
Meta color-scheme is allowed in body.

Per CSSWG resolution[1]. Also move the tests to wpt/html since the spec
is moving there per the same resolution.

Relevant spec pull requests are [2][3].

[1] w3c/csswg-drafts#3846 (comment)
[2] whatwg/html#5938
[3] w3c/csswg-drafts#5540

Bug: 1103669
Change-Id: I553c5ca8c1223cd746dc05471eb6d3c5d9d5f19b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380654
Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org>
Commit-Queue: Rune Lillesveen <futharkchromium.org>
Cr-Commit-Position: refs/heads/master{#810183}

--

wpt-commits: a3921bb66b03e89253c7a9b6f84bd37990cfe0b9
wpt-pr: 25756

UltraBlame original commit: 9beb603438ad982702d845608dbf65b566747412
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Sep 28, 2020
…=testonly

Automatic update from web-platform-tests
Meta color-scheme is allowed in body.

Per CSSWG resolution[1]. Also move the tests to wpt/html since the spec
is moving there per the same resolution.

Relevant spec pull requests are [2][3].

[1] w3c/csswg-drafts#3846 (comment)
[2] whatwg/html#5938
[3] w3c/csswg-drafts#5540

Bug: 1103669
Change-Id: I553c5ca8c1223cd746dc05471eb6d3c5d9d5f19b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380654
Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org>
Commit-Queue: Rune Lillesveen <futharkchromium.org>
Cr-Commit-Position: refs/heads/master{#810183}

--

wpt-commits: a3921bb66b03e89253c7a9b6f84bd37990cfe0b9
wpt-pr: 25756

UltraBlame original commit: 9beb603438ad982702d845608dbf65b566747412
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Sep 28, 2020
…=testonly

Automatic update from web-platform-tests
Meta color-scheme is allowed in body.

Per CSSWG resolution[1]. Also move the tests to wpt/html since the spec
is moving there per the same resolution.

Relevant spec pull requests are [2][3].

[1] w3c/csswg-drafts#3846 (comment)
[2] whatwg/html#5938
[3] w3c/csswg-drafts#5540

Bug: 1103669
Change-Id: I553c5ca8c1223cd746dc05471eb6d3c5d9d5f19b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380654
Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org>
Commit-Queue: Rune Lillesveen <futharkchromium.org>
Cr-Commit-Position: refs/heads/master{#810183}

--

wpt-commits: a3921bb66b03e89253c7a9b6f84bd37990cfe0b9
wpt-pr: 25756

UltraBlame original commit: 9beb603438ad982702d845608dbf65b566747412
sidvishnoi pushed a commit to sidvishnoi/gecko-webmonetization that referenced this pull request Oct 1, 2020
…=testonly

Automatic update from web-platform-tests
Meta color-scheme is allowed in body.

Per CSSWG resolution[1]. Also move the tests to wpt/html since the spec
is moving there per the same resolution.

Relevant spec pull requests are [2][3].

[1] w3c/csswg-drafts#3846 (comment)
[2] whatwg/html#5938
[3] w3c/csswg-drafts#5540

Bug: 1103669
Change-Id: I553c5ca8c1223cd746dc05471eb6d3c5d9d5f19b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380654
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810183}

--

wpt-commits: a3921bb66b03e89253c7a9b6f84bd37990cfe0b9
wpt-pr: 25756
bhearsum pushed a commit to mozilla-releng/staging-firefox that referenced this pull request May 1, 2025
…=testonly

Automatic update from web-platform-tests
Meta color-scheme is allowed in body.

Per CSSWG resolution[1]. Also move the tests to wpt/html since the spec
is moving there per the same resolution.

Relevant spec pull requests are [2][3].

[1] w3c/csswg-drafts#3846 (comment)
[2] whatwg/html#5938
[3] w3c/csswg-drafts#5540

Bug: 1103669
Change-Id: I553c5ca8c1223cd746dc05471eb6d3c5d9d5f19b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380654
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810183}

--

wpt-commits: a3921bb66b03e89253c7a9b6f84bd37990cfe0b9
wpt-pr: 25756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants