Skip to content

[css-font-loading] Remove step 3 from FontFaceSet.check() #5757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2020
Merged

[css-font-loading] Remove step 3 from FontFaceSet.check() #5757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions css-font-loading-3/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,14 +843,10 @@ The <code>check()</code> method</h3>
the method returns <code>true</code>,
as the text will be rendered in the UA's fallback font instead,
and won't trigger any font loads.
* If none of the specified fonts exist,
even though this is technically similar to the previous case
(in that text rendered with that font list would just use the UA fallback font),
the method instead throws an error.
This is because such a situation is almost certainly either a typo,
or the result of changing the name of a downloadable font
and forgetting to update all places the old name was used,
and an error is more useful than a vacuous <code>true</code>.
* Likewise, if none of the specified fonts exist (for example, names are mis-spelled),
the method also returns <code>true</code>,
because using this font list will not trigger any loads;
instead, fallback will occur.
</div>

When the <dfn method for="FontFaceSet" lt="check(font, text)|check(font)">check</dfn>(
Expand All @@ -872,11 +868,6 @@ The <code>check()</code> method</h3>
throw a SyntaxError exception
and terminate these steps.

<li>
If <var>found faces</var> is false,
throw an XXX error
and abort this algorithm.

<li>
If <var>font face list</var> is empty,
or all fonts in the <var>font face list</var> either have a {{FontFace/status}} attribute of "loaded" or are system fonts,
Expand Down