Skip to content

[css-ui-4] Add full <image> support for 'cursor' property #5834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

SebastianZ
Copy link
Contributor

This change replaces the currently defined <url> value supported by the cursor property by its superset <image>.

Closes #5831

Sebastian

Base automatically changed from master to main February 2, 2021 19:45
@frivoal
Copy link
Collaborator

frivoal commented Mar 25, 2021

I think this PR is premature unless UAs are actually implementing it. We absolutely should make sure that it's allowed, so that they can go in that direction, but making it a requirement is just going to slow down the spec if nobody is actually doing it. Until that changes (and I don't believe it has changed), I'd suggest closing.

@SebastianZ
Copy link
Contributor Author

@emilio just implemented image-set() for cursor in Gecko and another issue was filed lately by the Mozilla team to also support gradients on it. So at least Mozilla has implementation interest, it seems.

Maybe Emilio can provide an official statement here on their plans.

Sebastian

@emilio
Copy link
Collaborator

emilio commented Mar 25, 2021

We filed that bug just for tracking, but we're not particularly likely to get to it any time soon. I don't see a particular use case for gradients on a cursor and for $reasons it was harder to implement. image-set() (with urls) seemed worth supporting, and other browsers also support it.

@SebastianZ
Copy link
Contributor Author

Ok, so I close this change then and I'll come up with one that only adds image-set().

Sebastian

@SebastianZ SebastianZ closed this Mar 26, 2021
@tabatkins tabatkins reopened this Mar 30, 2021
@tabatkins
Copy link
Member

@emilio image-set() allows arbitrary <<image>>s in its arguments, including gradients. Are y'all only supporting a subset of image-set() functionality in this case? If so, maybe we should standardize that as a restricted type (similar to how only fixed-length values are allowed in repeat(auto-fit) for grids); if not, I don't think it makes sense to disallow something on its own that you could validly get just by wrapping it in an image-set().

@SebastianZ
Copy link
Contributor Author

@emilio Ping on @tabatkins' question.

@frivoal frivoal added the css-ui-4 Current Work label Dec 22, 2021
@SebastianZ
Copy link
Contributor Author

I close this now due to the lack of implementer support.

Sebastian

@SebastianZ SebastianZ closed this Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-ui-4 Current Work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[css-ui] Should the cursor property support image-set()?
4 participants