typo: Double words - #5951
Merged
Merged
Conversation
|
nschonni marked as non substantive for IPR from ash-nazg. |
tabatkins
requested changes
Feb 8, 2021
tabatkins
left a comment
Member
There was a problem hiding this comment.
A few necessary fixes, otherwise lgtm
| @@ -1,9377 +1,9407 @@ | |||
| <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> | |||
Member
There was a problem hiding this comment.
Woah, what happened with this file?
Contributor
Author
There was a problem hiding this comment.
Not sure if there was some encoding issue, but I can always remove it given the age
Member
There was a problem hiding this comment.
yeah, we should just, uh, not touch that file i guess. It's a generated file anyway.
Contributor
Author
|
@tabatkins dropped the "that" commit, and address the other comments except for the file that got "reencoded" or something. Don't think it was a line ending thing, since those were handled in another PR |
nschonni
added a commit
to nschonni/csswg-drafts
that referenced
this pull request
Feb 15, 2021
Co-authored-by: Rachel Andrew <rachel.andrew@edgeofmyseat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran Vale across the repo to find them and did one commit per word rather than multiple PRs by spec.
Looks like there might be some encoding issue in
css-page-3/lc-doc-20040215.htmthat's causing the large line diff count