[css-fonts-5] Specify the advance-override @font-face descriptor#5991
Merged
Conversation
svgeesus
reviewed
Feb 14, 2021
svgeesus
approved these changes
Feb 16, 2021
Contributor
|
(Missed it last Friday due to Chinese New Year...) Thanks for putting this up! During the meeting, we said there should be a second parameter to override the advance heights of the glyphs, in case we have vertical text where characters are not rotated. Do we still need it? |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 17, 2021
…erride This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b
pull Bot
pushed a commit
to Alan-love/chromium
that referenced
this pull request
Feb 18, 2021
We've implemented two variants so far: 1. advance-override: adds a fixed amount to the advance of each character 2. advance-proportional-override: scales the advance of each character by a fixed factor Now that the CSSWG has standardized the second variant and named it 'advance-override' [1], this patch removes the implementation of the first variant. A follow up patch will rename the second variant to 'advance-override'. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I65124a238614c3c95ab1b1f1aaf6b616c6070f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702291 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#854997}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 18, 2021
…erride This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#855390}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 18, 2021
…erride This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#855390}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 24, 2021
…tional-override to advance-override, a=testonly Automatic update from web-platform-tests [advance-override] Rename advance-proportional-override to advance-override This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#855390} -- wpt-commits: 7e4c574291142087f00efa00f782be03cebda75a wpt-pr: 27668
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Feb 25, 2021
…tional-override to advance-override, a=testonly Automatic update from web-platform-tests [advance-override] Rename advance-proportional-override to advance-override This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtrchromium.org> Commit-Queue: Xiaocheng Hu <xiaochenghchromium.org> Cr-Commit-Position: refs/heads/master{#855390} -- wpt-commits: 7e4c574291142087f00efa00f782be03cebda75a wpt-pr: 27668 UltraBlame original commit: c37c60d71a6bf5a82f0c74960652c524b32628c6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Feb 25, 2021
…tional-override to advance-override, a=testonly Automatic update from web-platform-tests [advance-override] Rename advance-proportional-override to advance-override This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtrchromium.org> Commit-Queue: Xiaocheng Hu <xiaochenghchromium.org> Cr-Commit-Position: refs/heads/master{#855390} -- wpt-commits: 7e4c574291142087f00efa00f782be03cebda75a wpt-pr: 27668 UltraBlame original commit: c37c60d71a6bf5a82f0c74960652c524b32628c6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Feb 25, 2021
…tional-override to advance-override, a=testonly Automatic update from web-platform-tests [advance-override] Rename advance-proportional-override to advance-override This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtrchromium.org> Commit-Queue: Xiaocheng Hu <xiaochenghchromium.org> Cr-Commit-Position: refs/heads/master{#855390} -- wpt-commits: 7e4c574291142087f00efa00f782be03cebda75a wpt-pr: 27668 UltraBlame original commit: c37c60d71a6bf5a82f0c74960652c524b32628c6
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 5, 2021
…tional-override to advance-override, a=testonly Automatic update from web-platform-tests [advance-override] Rename advance-proportional-override to advance-override This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#855390} -- wpt-commits: 7e4c574291142087f00efa00f782be03cebda75a wpt-pr: 27668
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 8, 2021
…tional-override to advance-override, a=testonly Automatic update from web-platform-tests [advance-override] Rename advance-proportional-override to advance-override This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#855390} -- wpt-commits: 7e4c574291142087f00efa00f782be03cebda75a wpt-pr: 27668
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 8, 2021
…tional-override to advance-override, a=testonly Automatic update from web-platform-tests [advance-override] Rename advance-proportional-override to advance-override This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#855390} -- wpt-commits: 7e4c574291142087f00efa00f782be03cebda75a wpt-pr: 27668
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 10, 2021
…tional-override to advance-override, a=testonly Automatic update from web-platform-tests [advance-override] Rename advance-proportional-override to advance-override This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtrchromium.org> Commit-Queue: Xiaocheng Hu <xiaochenghchromium.org> Cr-Commit-Position: refs/heads/master{#855390} -- wpt-commits: 7e4c574291142087f00efa00f782be03cebda75a wpt-pr: 27668 UltraBlame original commit: a1f4fc06b5f731150706cfdce51a580b5f878895
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 10, 2021
…tional-override to advance-override, a=testonly Automatic update from web-platform-tests [advance-override] Rename advance-proportional-override to advance-override This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtrchromium.org> Commit-Queue: Xiaocheng Hu <xiaochenghchromium.org> Cr-Commit-Position: refs/heads/master{#855390} -- wpt-commits: 7e4c574291142087f00efa00f782be03cebda75a wpt-pr: 27668 UltraBlame original commit: 7a1e3f821213262fa17270c47ea8e88285f2bd12
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 10, 2021
…tional-override to advance-override, a=testonly Automatic update from web-platform-tests [advance-override] Rename advance-proportional-override to advance-override This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtrchromium.org> Commit-Queue: Xiaocheng Hu <xiaochenghchromium.org> Cr-Commit-Position: refs/heads/master{#855390} -- wpt-commits: 7e4c574291142087f00efa00f782be03cebda75a wpt-pr: 27668 UltraBlame original commit: a1f4fc06b5f731150706cfdce51a580b5f878895
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 10, 2021
…tional-override to advance-override, a=testonly Automatic update from web-platform-tests [advance-override] Rename advance-proportional-override to advance-override This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtrchromium.org> Commit-Queue: Xiaocheng Hu <xiaochenghchromium.org> Cr-Commit-Position: refs/heads/master{#855390} -- wpt-commits: 7e4c574291142087f00efa00f782be03cebda75a wpt-pr: 27668 UltraBlame original commit: 7a1e3f821213262fa17270c47ea8e88285f2bd12
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 10, 2021
…tional-override to advance-override, a=testonly Automatic update from web-platform-tests [advance-override] Rename advance-proportional-override to advance-override This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtrchromium.org> Commit-Queue: Xiaocheng Hu <xiaochenghchromium.org> Cr-Commit-Position: refs/heads/master{#855390} -- wpt-commits: 7e4c574291142087f00efa00f782be03cebda75a wpt-pr: 27668 UltraBlame original commit: a1f4fc06b5f731150706cfdce51a580b5f878895
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 10, 2021
…tional-override to advance-override, a=testonly Automatic update from web-platform-tests [advance-override] Rename advance-proportional-override to advance-override This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtrchromium.org> Commit-Queue: Xiaocheng Hu <xiaochenghchromium.org> Cr-Commit-Position: refs/heads/master{#855390} -- wpt-commits: 7e4c574291142087f00efa00f782be03cebda75a wpt-pr: 27668 UltraBlame original commit: 7a1e3f821213262fa17270c47ea8e88285f2bd12
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
…tional-override to advance-override, a=testonly Automatic update from web-platform-tests [advance-override] Rename advance-proportional-override to advance-override This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#855390} -- wpt-commits: 7e4c574291142087f00efa00f782be03cebda75a wpt-pr: 27668
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…tional-override to advance-override, a=testonly Automatic update from web-platform-tests [advance-override] Rename advance-proportional-override to advance-override This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#855390} -- wpt-commits: 7e4c574291142087f00efa00f782be03cebda75a wpt-pr: 27668
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…tional-override to advance-override, a=testonly Automatic update from web-platform-tests [advance-override] Rename advance-proportional-override to advance-override This is the follow up of crrev.com/c/2702291 Now that the CSSWG has standardized a descriptor 'advance-override' [1], which works exactly the same as the 'advance-proportional-override', this patch renames it to 'advance-override' to match the spec. There's also a test moved from wpt_internal to wpt since it has been standardized now. [1] w3c/csswg-drafts#5991 Bug: 1137633 Change-Id: I85d8cc5e3fef0315c36d1436cb21f1d4be85b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702477 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#855390} -- wpt-commits: 7e4c574291142087f00efa00f782be03cebda75a wpt-pr: 27668
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify the advance-override @font-face descriptor
cc @xiaochengh @svgeesus