-
Notifications
You must be signed in to change notification settings - Fork 765
fix: typos across specs #5992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typos across specs #5992
Conversation
|
Wow, this must have taken a long time to get right. Thanks for putting it together! No need to split across specs, it's actually easier to review like this. Want to confirm s/targetted/targeting/ with @tabatkins, but aside from that everything else looks correct. The one bit that needs adjustment is that in the issues-* files, removing a letter from a key needs to add a space so that the values all continue to line up. :) |
|
I had separately pulled out the "Typogrraphy" one, and @svgeesus pointed out that some of the older specs like css-fonts-3 have hit the point were they shouldn't really be touched. |
|
If you can merge in those whitespace fixes, I can merge in your PR. |
Co-authored-by: fantasai <fantasai.bugs@inkedblade.net>
fantasai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to unmark it as a draft for me to merge.
|
@fantasai I'm un-marked it as draft, but I'm not sure what parts might still need to be rebased out because they've hit CR now |
|
None, it merged cleanly. :) Thanks~ |
This probably needs to get re-submitted in smaller chunks. I went across the repo using cSpell and fixed word-by-word creating this large PR.
Possible alternate approach would be to collapse this down and then re-submit by spec folder.
If going with the flattened folder-by-folder, should the various
issue*files be ignored? There were some with incorrect key names.