Skip to content

Conversation

@nschonni
Copy link
Contributor

@nschonni nschonni commented Feb 14, 2021

This probably needs to get re-submitted in smaller chunks. I went across the repo using cSpell and fixed word-by-word creating this large PR.
Possible alternate approach would be to collapse this down and then re-submit by spec folder.

If going with the flattened folder-by-folder, should the various issue* files be ignored? There were some with incorrect key names.

@nschonni nschonni marked this pull request as draft February 18, 2021 03:10
@fantasai
Copy link
Collaborator

Wow, this must have taken a long time to get right. Thanks for putting it together! No need to split across specs, it's actually easier to review like this. Want to confirm s/targetted/targeting/ with @tabatkins, but aside from that everything else looks correct. The one bit that needs adjustment is that in the issues-* files, removing a letter from a key needs to add a space so that the values all continue to line up. :)

@nschonni
Copy link
Contributor Author

I had separately pulled out the "Typogrraphy" one, and @svgeesus pointed out that some of the older specs like css-fonts-3 have hit the point were they shouldn't really be touched.
If you want to comment inline on any specific ones that should be pulled or reformmated, I can try and rebase out the particular changes

@fantasai
Copy link
Collaborator

If you can merge in those whitespace fixes, I can merge in your PR.

Co-authored-by: fantasai <fantasai.bugs@inkedblade.net>
Copy link
Collaborator

@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to unmark it as a draft for me to merge.

@nschonni nschonni marked this pull request as ready for review February 21, 2021 03:44
@nschonni
Copy link
Contributor Author

@fantasai I'm un-marked it as draft, but I'm not sure what parts might still need to be rebased out because they've hit CR now

@fantasai fantasai merged commit b554cf5 into w3c:main Feb 22, 2021
@fantasai
Copy link
Collaborator

None, it merged cleanly. :) Thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants