Add the second percentage parameter to advance-override #6020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
svgeesus
approved these changes
Feb 22, 2021
Contributor
Author
|
Thanks! |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 22, 2021
For upright characters in vertical text layout, the advance of a glyph is its height instead of width, and therefore we may want a different scale factor for overriding the advance height instead of width. Hence, following the spec revision [1], this patch implements the second parameter for use in upright glyphs in vertical text layout. [1] w3c/csswg-drafts#6020 Bug: 1137633 Change-Id: I277d84711b9478f21ba3bd1b3aa987196fb0499e
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 23, 2021
For upright characters in vertical text layout, the advance of a glyph is its height instead of width, and therefore we may want a different scale factor for overriding the advance height instead of width. Hence, following the spec revision [1], this patch implements the second parameter for use in upright glyphs in vertical text layout. [1] w3c/csswg-drafts#6020 Bug: 1137633 Change-Id: I277d84711b9478f21ba3bd1b3aa987196fb0499e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706243 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#856529}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 23, 2021
For upright characters in vertical text layout, the advance of a glyph is its height instead of width, and therefore we may want a different scale factor for overriding the advance height instead of width. Hence, following the spec revision [1], this patch implements the second parameter for use in upright glyphs in vertical text layout. [1] w3c/csswg-drafts#6020 Bug: 1137633 Change-Id: I277d84711b9478f21ba3bd1b3aa987196fb0499e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706243 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#856529}
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Feb 23, 2021
For upright characters in vertical text layout, the advance of a glyph is its height instead of width, and therefore we may want a different scale factor for overriding the advance height instead of width. Hence, following the spec revision [1], this patch implements the second parameter for use in upright glyphs in vertical text layout. [1] w3c/csswg-drafts#6020 Bug: 1137633 Change-Id: I277d84711b9478f21ba3bd1b3aa987196fb0499e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706243 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#856529}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 15, 2021
…percentage parameter, a=testonly Automatic update from web-platform-tests [advance-override] Implement the second percentage parameter For upright characters in vertical text layout, the advance of a glyph is its height instead of width, and therefore we may want a different scale factor for overriding the advance height instead of width. Hence, following the spec revision [1], this patch implements the second parameter for use in upright glyphs in vertical text layout. [1] w3c/csswg-drafts#6020 Bug: 1137633 Change-Id: I277d84711b9478f21ba3bd1b3aa987196fb0499e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706243 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#856529} -- wpt-commits: f70aca56a3e5be65fd4d67ee64ca5dbb3ee9413b wpt-pr: 27691
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 15, 2021
…percentage parameter, a=testonly Automatic update from web-platform-tests [advance-override] Implement the second percentage parameter For upright characters in vertical text layout, the advance of a glyph is its height instead of width, and therefore we may want a different scale factor for overriding the advance height instead of width. Hence, following the spec revision [1], this patch implements the second parameter for use in upright glyphs in vertical text layout. [1] w3c/csswg-drafts#6020 Bug: 1137633 Change-Id: I277d84711b9478f21ba3bd1b3aa987196fb0499e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706243 Commit-Queue: Xiaocheng Hu <xiaochenghchromium.org> Reviewed-by: Koji Ishii <kojiichromium.org> Cr-Commit-Position: refs/heads/master{#856529} -- wpt-commits: f70aca56a3e5be65fd4d67ee64ca5dbb3ee9413b wpt-pr: 27691 UltraBlame original commit: 66c731d15ae3e25ec285642e8232011efca17c9e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 15, 2021
…percentage parameter, a=testonly Automatic update from web-platform-tests [advance-override] Implement the second percentage parameter For upright characters in vertical text layout, the advance of a glyph is its height instead of width, and therefore we may want a different scale factor for overriding the advance height instead of width. Hence, following the spec revision [1], this patch implements the second parameter for use in upright glyphs in vertical text layout. [1] w3c/csswg-drafts#6020 Bug: 1137633 Change-Id: I277d84711b9478f21ba3bd1b3aa987196fb0499e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706243 Commit-Queue: Xiaocheng Hu <xiaochenghchromium.org> Reviewed-by: Koji Ishii <kojiichromium.org> Cr-Commit-Position: refs/heads/master{#856529} -- wpt-commits: f70aca56a3e5be65fd4d67ee64ca5dbb3ee9413b wpt-pr: 27691 UltraBlame original commit: 66c731d15ae3e25ec285642e8232011efca17c9e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 15, 2021
…percentage parameter, a=testonly Automatic update from web-platform-tests [advance-override] Implement the second percentage parameter For upright characters in vertical text layout, the advance of a glyph is its height instead of width, and therefore we may want a different scale factor for overriding the advance height instead of width. Hence, following the spec revision [1], this patch implements the second parameter for use in upright glyphs in vertical text layout. [1] w3c/csswg-drafts#6020 Bug: 1137633 Change-Id: I277d84711b9478f21ba3bd1b3aa987196fb0499e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706243 Commit-Queue: Xiaocheng Hu <xiaochenghchromium.org> Reviewed-by: Koji Ishii <kojiichromium.org> Cr-Commit-Position: refs/heads/master{#856529} -- wpt-commits: f70aca56a3e5be65fd4d67ee64ca5dbb3ee9413b wpt-pr: 27691 UltraBlame original commit: 66c731d15ae3e25ec285642e8232011efca17c9e
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…percentage parameter, a=testonly Automatic update from web-platform-tests [advance-override] Implement the second percentage parameter For upright characters in vertical text layout, the advance of a glyph is its height instead of width, and therefore we may want a different scale factor for overriding the advance height instead of width. Hence, following the spec revision [1], this patch implements the second parameter for use in upright glyphs in vertical text layout. [1] w3c/csswg-drafts#6020 Bug: 1137633 Change-Id: I277d84711b9478f21ba3bd1b3aa987196fb0499e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706243 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#856529} -- wpt-commits: f70aca56a3e5be65fd4d67ee64ca5dbb3ee9413b wpt-pr: 27691
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the previous discussion, this patch adds the second percentage parameter to
advance-overridefor upright glyphs in vertical text layout.