Skip to content

[css-fonts-4] font-optical-sizing interacts with font-size-adjust #6196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2021
Merged

[css-fonts-4] font-optical-sizing interacts with font-size-adjust #6196

merged 1 commit into from
Apr 9, 2021

Conversation

litherum
Copy link
Contributor

@litherum litherum commented Apr 9, 2021

Fixes #6190.

@litherum litherum requested review from drott, jfkthame and svgeesus April 9, 2021 07:22
@litherum litherum force-pushed the font-optical-sizing-font-size-adjust branch from 97d3ff4 to 49fe5cf Compare April 9, 2021 07:23
@litherum litherum force-pushed the font-optical-sizing-font-size-adjust branch from 49fe5cf to 7a980e0 Compare April 9, 2021 07:24
@drott
Copy link
Collaborator

drott commented Apr 9, 2021

Thanks for the quick edit, Myles.

Fixes #6190.

This change fixes the equivalent issue for font-size-adjust. It might be that you were already on it, but AFAICS we would also need an edit that clarifies this for https://drafts.csswg.org/css-fonts-5/#size-adjust-desc.

svgeesus
svgeesus approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drott drott merged commit df08616 into w3c:main Apr 9, 2021
@drott
Copy link
Collaborator

drott commented Apr 9, 2021

Oups, sorry, I was a bit quick to click the merge button. I had confused this PR with this one with my new tests. Should we revert and let Myles land it, after @jfkthame commented as well, or leave it in for now?

@svgeesus
Copy link
Contributor

svgeesus commented Apr 9, 2021

I think it is easier to leave it, we can always add more edits on top.

@svgeesus
Copy link
Contributor

svgeesus commented Apr 9, 2021

And yes that was super fast :)

@litherum litherum deleted the font-optical-sizing-font-size-adjust branch April 9, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svgeesus svgeesus svgeesus approved these changes

@drott drott Awaiting requested review from drott

@jfkthame jfkthame Awaiting requested review from jfkthame

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[css-fonts] Clarify font-optical-sizing behaviour under size-adjust
3 participants
@litherum @drott @svgeesus