[web-animations-2] Fix WebIDL - no inherit for partial dictionary #6267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per WebIDL, a partial dictionary declaration cannot inherit from a base dictionary. See Note in: https://heycam.github.io/webidl/#idl-interfaces "Note: A partial interface definition cannot specify that the interface inherits from another interface. Inheritance must be specified on the original interface definition." `ComputedEffectTiming`, defined in Level 1, already inherits from `EffectTiming`, so no need to formulate that again in the partial definition.
Contributor
|
Thank you! |
tidoust
added a commit
to tidoust/csswg-drafts
that referenced
this pull request
May 6, 2021
Previous fix made WebIDL parse-able: w3c#6267 However, the WebIDL remains invalid because `void` has now been replaced by `undefined` in WebIDL and because optional dictionary parameters with no required members need to have a default value. This update fixes these validity issues.
birtles
pushed a commit
that referenced
this pull request
May 6, 2021
Previous fix made WebIDL parse-able: #6267 However, the WebIDL remains invalid because `void` has now been replaced by `undefined` in WebIDL and because optional dictionary parameters with no required members need to have a default value. This update fixes these validity issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per WebIDL, a partial dictionary declaration cannot inherit from a base dictionary. See Note in:
https://heycam.github.io/webidl/#idl-interfaces
"Note: A partial interface definition cannot specify that the interface inherits from another interface. Inheritance must be specified on the original interface definition."
ComputedEffectTiming, defined in Level 1, already inherits fromEffectTiming, so no need to formulate that again in the partial definition.[css-spec-shortname-1] Brief description which should also include the #issuenum-or-URL and/or link to relevant CSSWG minutes.