Skip to content

Conversation

@argyleink
Copy link

[css-nesting-1] fixes #3748

Felt sufficient to demonstrate the result of a BEM style nesting selector, as opposed to a note specifically calling out BEM. The answer is in the examples.

@argyleink argyleink requested a review from tabatkins May 7, 2021 22:01
@argyleink argyleink self-assigned this May 7, 2021
@tabatkins
Copy link
Member

I think it's worth pulling this out into a separate example with an explicit call-out, actually. Don't have to mention BEM, but a general reference to "concatenating" that some preprocessors with this feature can do would be useful.

@plinss
Copy link
Member

plinss commented May 16, 2021

@argyleink in the future, please don't create branches in the main repo for PRs. Fork the repo into your personal space and create branches there and PRs from there.

Having additional branches puts an extra workload on the draft server CI system and also can cause issues with the hg/git sync.

@argyleink
Copy link
Author

well, i'm still in the process of making a pr of this work from a fork.. but i need to fix the commit i added 🤦🏻 i've made it worse trying to delete this branch. i'm sorry!

@tabatkins tabatkins merged commit e8e14b8 into main Jun 12, 2021
@tabatkins tabatkins deleted the css-nesting-1-bem-mention branch June 12, 2021 16:49
@syncbot syncbot restored the css-nesting-1-bem-mention branch July 22, 2021 05:04
@argyleink argyleink deleted the css-nesting-1-bem-mention branch July 23, 2021 15:53
@syncbot syncbot restored the css-nesting-1-bem-mention branch October 26, 2021 01:09
@plinss plinss deleted the css-nesting-1-bem-mention branch October 27, 2021 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[css-nesting] add note explaining that BEM &__element class accumulation isn't supported and why

4 participants