Skip to content

[cssom] Handle custom properties separately. #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2016
Merged

[cssom] Handle custom properties separately. #631

merged 1 commit into from
Nov 14, 2016

Conversation

@upsuper
Copy link
Member

@upsuper upsuper commented Oct 20, 2016 •
edited by SimonSapin
Loading

Fixes #630, fixes #580.

@upsuper
Copy link
Member Author

upsuper commented Oct 21, 2016

So this should fix #580.

@upsuper upsuper added the cssom-1 Current Work label Nov 11, 2016
@zcorpan
Copy link
Contributor

zcorpan commented Nov 14, 2016

Thanks @upsuper!

@SimonSapin does this look good to you?

@SimonSapin
Copy link
Contributor

SimonSapin commented Nov 14, 2016

Looks good, thanks!

@SimonSapin SimonSapin merged commit 7083116 into w3c:master Nov 14, 2016
@tim-loh
Copy link

tim-loh commented Dec 12, 2016

I think getComputedStyle needs to be updated too:

declarations
All longhand properties that are supported CSS properties, in lexicographical order, with the value being the resolved value computed for obj using the style rules associated with doc.

@upsuper upsuper deleted the cssom-custom-property branch December 12, 2016 05:07
@upsuper
Copy link
Member Author

upsuper commented Dec 12, 2016

You can open a new pull request for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@zcorpan zcorpan

@therealglazou therealglazou

Labels

cssom-1 Current Work

Projects

None yet

Milestone

No milestone

5 participants

@upsuper @zcorpan @SimonSapin @tim-loh @therealglazou