[css-fonts-5] Extend font-size-adjust #6382
Conversation
| <dt><dfn>ch</dfn> | ||
| <dd> | ||
| Normalize the narrow pitch of the fonts, | ||
| using the advance measure of “0” (ZERO, U+0030) |
There was a problem hiding this comment.
The advance measure of 0 is different depending on the writing mode (general case vs vertical upright). Does this mean that when specified with ch font-size-adjust is expect to stretch things by a different amount depending on the writing mode? I suspect not, but then it would be good to be clear that we're talking about the width of the glyph, since advance measure is defined to vary based on writing modes.
Alternatively, we do want to be writing-mode sensitive, but then ch probably should be paired with 2 rather than 1 numbers.
There was a problem hiding this comment.
Can you adapt your comment to #6288 ?
There was a problem hiding this comment.
Having font-size-adjust be writing-mode sensitive seems to me unlikely to really be useful/desired, so I feel it would add complexity without adding value.
What could make sense would be to accept explicit vertical-measure values ch-height and ic-height, which could be used when a design is focused on vertical writing modes.
I would also propose renaming the ch and ic keywords here to ch-width and ic-width to make it clear what they represent, as they do not correspond directly with the similarly-named units (which are writing-mode dependent).
There was a problem hiding this comment.
@jfkthame Let's tackle this discussion in the issue you filed? :) Rather than here.
There was a problem hiding this comment.
If there is no glyph corresponding to "0"? Edit ah okay existing issue
cbcd5eb to
2f91613
Compare
| @@ -381,8 +603,15 @@ No new security or privacy considerations have been raised on this specification | |||
| <h2 id="acknowledgments"> | |||
| Acknowledgments</h2> | |||
|
|
|||
| The CSS Working group would like to thank: | |||
| Firstly, the editors would like to thank all of the | |||
| <a href="https://www.w3.org/TR/css-fonts-4/#acknowledgments">contributors to the previous level of this module</a>. | |||
There was a problem hiding this comment.
(Improving the Fonts 4 ack list is on my todo)
css-fonts-5/Overview.bs
Outdated
| <dt><dfn>from-font</dfn> | ||
| <dd> | ||
| Computes to the <<number>> corresponding to | ||
| the <a>aspect value</a> of the [=first available font=]. |
There was a problem hiding this comment.
What is the actual effect of 'from-font' for the primary font? Maybe, no size adjustment, right? Because m and m' are the same in the equation below.
u = ( m / m′ ) s
s = computed 'font-size-property' value
m = metric as specified by the 'font-size-adjust' property
m′ = metric as specified in the actual font
u = adjusted font-size to use
There was a problem hiding this comment.
Yes, exactly. The intent is that from-font makes it easy to leave the primary font untouched, and adjust fallbacks appropriately to match it.
There was a problem hiding this comment.
I see. Thanks for the clarification.
DO NOT SQUASH WHEN MERGING!!!!!!!!!!!!!!!!!!!!