Skip to content

[css-conditional-4] Extend supports feature to express font capabilities #6613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

drott
Copy link
Collaborator

@drott drott commented Sep 15, 2021

Define criteria for enabling @supports to distinguish support for
a set of font technologies defined in the grammar.

Addresses resolution in #6520 to add criteria for font technologies as a
first step.

Incorporates @LeaVerou 's feedback from [1]

[1] #6520 (comment)

Define criteria for enabling @supports to distinguish support for
a set of font technologies defined in the grammar.

Addresses resolution in w3c#6520 to add criteria for font technologies as a
first step.

Incorporates @LeaVerou 's feedback from [1]

[1] w3c#6520 (comment)
@drott
Copy link
Collaborator Author

drott commented Sep 15, 2021

@litherum wrote:

Please add a note saying this is not ready for implementation yet (though similar/identical grammar is ready for implementation inside the src: descriptor). It also might be worth saying that implementing this depends on implementing @else.

@drott
Copy link
Collaborator Author

drott commented Sep 15, 2021

From the minutes:

#6520 (comment)

<fantasai> RESOLVED: Accept the PR
<chris> :)
<fantasai> myles: Can we add a note to the PR to say "don't implement this yet, implement this other thing first"
<fantasai> astearns: open an issue

@drott
Copy link
Collaborator Author

drott commented Sep 15, 2021

I suggest we merge this, as was discussed, and decide on the form of the note in a separate issue / PR.

From my point of view, no objections to a note saying, for example: "Implementers should consider shipping this in combination with an @else addition to @supports . Changes to details of the grammar are still expected."

It also might be worth saying that implementing this depends on implementing @else.

I don't think this matches what was resolved.

CC @fantasai

@drott drott requested a review from svgeesus September 15, 2021 17:24
drott referenced this pull request in drott/csswg-drafts Sep 15, 2021
Defining the criteria for enabling @supports to distinguish support for
a set of font technologies defined in the grammar.

Addresses resolution in w3c#6520 to add criteria for font technologies as a
first step.
@litherum
Copy link
Contributor

litherum commented Sep 15, 2021

Implementations should not ship the @supports feature without @else, because if you only give authors the wrong way to do something, they're going to do it wrong.

Implementations may ship the src: feature without @else.

The syntaxes for @supports and src: can be unified, too (as @fantasai requested during today's call).

This gives Chrome a natural path to shipping - first, the WG can unify the syntaxes for @supports and src:, and then Chrome can ship the new and improved src: syntax while the WG works on @else. Then, when @else is ready, that can ship alongside the new and improved syntax in @supports. I believe this makes everyone happy.

@litherum
Copy link
Contributor

@jfkthame

@LeaVerou
Copy link
Member

@litherum as discussed in the call, please open a new issue about this. We have a resolution to merge this PR, and it is not appropriate to be making substantive changes to a PR we have already resolved to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants