Skip to content

[css-fonts] [palettes] Remove the <string> values from override-color and base-palette #6651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svgeesus merged 1 commit into from
Oct 12, 2021
Merged

[css-fonts] [palettes] Remove the <string> values from override-color and base-palette #6651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 7 additions & 21 deletions css-fonts-4/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6465,7 +6465,7 @@ Specifying the base palette: the 'base-palette' descriptor</h4>

<pre class='descdef'>
Name: base-palette
Value: light | dark | <<integer [0, ∞]>> | <<string>>
Value: light | dark | <<integer [0, ∞]>>
For: @font-palette-values
Initial: N/A
</pre>
Expand Down Expand Up @@ -6495,11 +6495,6 @@ Specifying the base palette: the 'base-palette' descriptor</h4>
<dd>
Identifies a (zero-based) numerical palette index within the font.


<dt><dfn type><<string>></dfn>
<dd>
Identifies a named palette within the font.

</dl>

<div class="example">
Expand All @@ -6508,11 +6503,11 @@ Specifying the base palette: the 'base-palette' descriptor</h4>
<pre>
@font-palette-values Festival {
font-family: Banner Flag;
base-palette: 'Dark';
base-palette: 1;
override-colors:
'Outline' rgb(123, 64, 27),
'Base Glyph' currentColor,
'Glints' var(--highlight);
0 rgb(123, 64, 27),
1 currentColor,
2 var(--highlight);
}
</pre>
</div>
Expand Down Expand Up @@ -6546,16 +6541,12 @@ Specifying the base palette: the 'base-palette' descriptor</h4>
Colors in the palette can be overridden
by using the 'override-color!!descriptor' descriptor in the ''@font-palette-values'' rule.

Strings specified in the value of this descriptor
are matched
according to [[#localized-name-matching]].

<h4 id="override-color">
Overriding a colors from a palette: The 'override-colors!!descriptor' descriptor</h4>

<pre class='descdef'>
Name: override-colors
Value: [ [ <<string>> | <<integer [0, ∞]>> ] <<absolute-color>> ]#
Value: [ <<integer [0, ∞]>> <<absolute-color>> ]#
For: @font-palette-values
Initial: N/A
</pre>
Expand All @@ -6574,12 +6565,7 @@ Overriding a colors from a palette: The 'override-colors!!descriptor' descriptor

Palette index entries
in the ''@font-palette-values/override-colors'' descriptor
are either a (zero-based) palette index entry, or
a string, which corresponds to a named palette entry
in the selected palette.

Strings specified in the value of this descriptor
are matched according to [[#localized-name-matching]].
are a (zero-based) palette index entry.

Integer values are zero-indexed.

Expand Down