Skip to content

[css-fonts] [palettes] override-color takes a list but isn't plural #6652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2021
Merged

[css-fonts] [palettes] override-color takes a list but isn't plural #6652

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09ddc0c
[css-fonts] [palettes] override-color takes a list but isn't plural
litherum Sep 21, 2021
c703cc6
Merge branch 'main' into override-colors
svgeesus Sep 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions css-fonts-4/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6373,7 +6373,7 @@ User-defined font color palettes: The ''@font-palette-values'' rule</h3>
@font-palette-values Cooler {
font-family: Bixa;
base-palette: 1;
override-color:
override-colors:
1 #7EB7E4;
}
</pre>
Expand All @@ -6393,7 +6393,7 @@ User-defined font color palettes: The ''@font-palette-values'' rule</h3>
@font-palette-values Augusta {
font-family: Handover Sans;
base-palette: 3;
override-color:
override-colors:
1 rgb(43, 12, 9),
3 var(--highlight);
}
Expand Down Expand Up @@ -6512,7 +6512,7 @@ Specifying the base palette: the 'base-palette' descriptor</h4>
@font-palette-values Festival {
font-family: Banner Flag;
base-palette: 'Dark';
override-color:
override-colors:
'Outline' rgb(123, 64, 27),
'Base Glyph' currentColor,
'Glints' var(--highlight);
Expand All @@ -6522,10 +6522,10 @@ Specifying the base palette: the 'base-palette' descriptor</h4>

This descriptor specifies a palette in the font
which the containing ''@font-palette-values'' rule uses as an initial value.
If no <<override-color>> key is present in the ''@font-palette-values'' rule,
If no <<override-colors>> key is present in the ''@font-palette-values'' rule,
then the ''@font-palette-values'' rule represents the palette in the font
with the same index as the value of this descriptor.
If a <<override-color>> key is present in the ''@font-palette-values'' rule,
If a <<override-colors>> key is present in the ''@font-palette-values'' rule,
each item in the value of that descriptor overrides a single color
in the color palette represented by this ''@font-palette-values'' block.

Expand Down Expand Up @@ -6554,10 +6554,10 @@ Specifying the base palette: the 'base-palette' descriptor</h4>
according to [[#localized-name-matching]].

<h4 id="override-color">
Overriding a color from a palette: The 'override-color!!descriptor' descriptor</h4>
Overriding a colors from a palette: The 'override-colors!!descriptor' descriptor</h4>

<pre class='descdef'>
Name: override-color
Name: override-colors
Value: [ [ <<string>> | <<integer [0, ∞]>> ] <<color>> ]#
For: @font-palette-values
Initial: N/A
Expand All @@ -6576,12 +6576,12 @@ Overriding a color from a palette: The 'override-color!!descriptor' descriptor</
an entry into the palette
an a color to replace it with.

The '@font-palette-values/override-color' descriptor takes
The '@font-palette-values/override-colors' descriptor takes
a comma-separated list
of palette index entries and colors.

Palette index entries
in the ''@font-palette-values/override-color'' descriptor
in the ''@font-palette-values/override-colors'' descriptor
are either a (zero-based) palette index entry, or
a string, which corresponds to a named palette entry
in the selected palette.
Expand Down