Skip to content

Conversation

@delan
Copy link
Contributor

@delan delan commented Sep 22, 2021

This patch makes edits for #6264:

  • adds a section stating that custom properties are allowed on all pseudos
  • explicitly clarifies that non-inherited registered customs are also inherited

One thing I’m unsure of… should we restate or refer to this near the lists of applicable properties? Especially with the one for ::marker, which is in a separate spec, the reader could miss this if they’ve only read the section about a specific pseudo.

@delan delan changed the title [css-pseudo] highlight pseudos and custom properties (#6264) [css-pseudo-4] highlight pseudos and custom properties (#6264) Sep 22, 2021
@delan delan requested review from fantasai and frivoal September 23, 2021 12:04
@delan delan marked this pull request as ready for review September 23, 2021 12:04
@delan delan changed the title [css-pseudo-4] highlight pseudos and custom properties (#6264) [css-pseudo-4] highlight pseudos and custom properties (closes #6264) Nov 2, 2021
@delan delan added the css-pseudo-4 Current Work label Nov 2, 2021
@delan delan changed the title [css-pseudo-4] highlight pseudos and custom properties (closes #6264) [css-pseudo] highlight pseudos and custom properties (closes #6264) Nov 2, 2021
Copy link
Collaborator

@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second half looks good.

For the first half, I think it would be better if we put this into the definition of custom properties. E.g.

- Applies to: all elements
+ Applies to: all elements and all pseudo-elements (including those with restricted property lists)

I think that'll be a less awkward place to put it, and makes it an integral part of the definition of exactly the thing it applies to.

@delan
Copy link
Contributor Author

delan commented Jan 25, 2022

Thanks @fantasai, done in e0adc21. Do we need to pull Tab in as reviewer for the css-variables part?

@delan delan changed the title [css-pseudo] highlight pseudos and custom properties (closes #6264) [css-pseudo][css-variables] highlight pseudos and custom properties (closes #6264) Jan 25, 2022
@delan delan requested a review from fantasai January 25, 2022 06:36
@tabatkins
Copy link
Member

r+ on the Variables edit

@delan delan requested review from Loirooriol, fantasai and frivoal and removed request for astearns, fantasai, frivoal and therealglazou April 15, 2022 08:43
@delan delan changed the title [css-pseudo][css-variables] highlight pseudos and custom properties (closes #6264) [css-pseudo] [css-variables] highlight pseudos and custom properties (closes #6264) Apr 15, 2022
@fantasai fantasai merged commit d5164d2 into w3c:main Apr 19, 2022
@delan delan deleted the custom-properties-on-pseudos branch April 20, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css-pseudo-4 Current Work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants