-
Notifications
You must be signed in to change notification settings - Fork 719
[css-pseudo] [css-variables] highlight pseudos and custom properties (closes #6264) #6663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second half looks good.
For the first half, I think it would be better if we put this into the definition of custom properties. E.g.
- Applies to: all elements
+ Applies to: all elements and all pseudo-elements (including those with restricted property lists)
I think that'll be a less awkward place to put it, and makes it an integral part of the definition of exactly the thing it applies to.
r+ on the Variables edit |
This patch makes edits for #6264:
One thing I’m unsure of… should we restate or refer to this near the lists of applicable properties? Especially with the one for ::marker, which is in a separate spec, the reader could miss this if they’ve only read the section about a specific pseudo.