[web-animation-2] Include CSSNumberish as a valid type for EffectTiming duration - #6703
Merged
Merged
Conversation
flackr
approved these changes
Sep 30, 2021
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 5, 2021
When using a scroll timeline with an animation, calling getComputedTiming().duration on its effect will now return a CSSNumericValue containaning the computed percentage. This change brings our implementation in line with recent spec changes: w3c/csswg-drafts#6703 Bug: 1251374 Change-Id: I3ae227f9ca74ad09f29c0cc73e88bd7a5e4758e2
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 6, 2021
When using a scroll timeline with an animation, calling getComputedTiming().duration on its effect will now return a CSSNumericValue containaning the computed percentage. This change brings our implementation in line with recent spec changes: w3c/csswg-drafts#6703 Bug: 1251374 Change-Id: I3ae227f9ca74ad09f29c0cc73e88bd7a5e4758e2
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 6, 2021
When using a scroll timeline with an animation, calling getComputedTiming().duration on its effect will now return a CSSNumericValue containaning the computed percentage. This change brings our implementation in line with recent spec changes: w3c/csswg-drafts#6703 Bug: 1251374 Change-Id: I3ae227f9ca74ad09f29c0cc73e88bd7a5e4758e2
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 7, 2021
When using a scroll timeline with an animation, calling getComputedTiming().duration on its effect will now return a CSSNumericValue containaning the computed percentage. This change brings our implementation in line with recent spec changes: w3c/csswg-drafts#6703 Bug: 1251374 Change-Id: I3ae227f9ca74ad09f29c0cc73e88bd7a5e4758e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206667 Reviewed-by: Kevin Ellis <kevers@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#929410}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 7, 2021
When using a scroll timeline with an animation, calling getComputedTiming().duration on its effect will now return a CSSNumericValue containaning the computed percentage. This change brings our implementation in line with recent spec changes: w3c/csswg-drafts#6703 Bug: 1251374 Change-Id: I3ae227f9ca74ad09f29c0cc73e88bd7a5e4758e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206667 Reviewed-by: Kevin Ellis <kevers@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#929410}
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Oct 8, 2021
When using a scroll timeline with an animation, calling getComputedTiming().duration on its effect will now return a CSSNumericValue containaning the computed percentage. This change brings our implementation in line with recent spec changes: w3c/csswg-drafts#6703 Bug: 1251374 Change-Id: I3ae227f9ca74ad09f29c0cc73e88bd7a5e4758e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206667 Reviewed-by: Kevin Ellis <kevers@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#929410}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 14, 2021
…alue for computed effect timing, a=testonly Automatic update from web-platform-tests Converted duration to return CSSNumericValue for computed effect timing When using a scroll timeline with an animation, calling getComputedTiming().duration on its effect will now return a CSSNumericValue containaning the computed percentage. This change brings our implementation in line with recent spec changes: w3c/csswg-drafts#6703 Bug: 1251374 Change-Id: I3ae227f9ca74ad09f29c0cc73e88bd7a5e4758e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206667 Reviewed-by: Kevin Ellis <kevers@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#929410} -- wpt-commits: 342effc0d1b4ac6012201175495d17a2718f8152 wpt-pr: 31126
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Oct 14, 2021
…alue for computed effect timing, a=testonly Automatic update from web-platform-tests Converted duration to return CSSNumericValue for computed effect timing When using a scroll timeline with an animation, calling getComputedTiming().duration on its effect will now return a CSSNumericValue containaning the computed percentage. This change brings our implementation in line with recent spec changes: w3c/csswg-drafts#6703 Bug: 1251374 Change-Id: I3ae227f9ca74ad09f29c0cc73e88bd7a5e4758e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206667 Reviewed-by: Kevin Ellis <kevers@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#929410} -- wpt-commits: 342effc0d1b4ac6012201175495d17a2718f8152 wpt-pr: 31126
Gabisampaio
pushed a commit
to Gabisampaio/wpt
that referenced
this pull request
Nov 18, 2021
When using a scroll timeline with an animation, calling getComputedTiming().duration on its effect will now return a CSSNumericValue containaning the computed percentage. This change brings our implementation in line with recent spec changes: w3c/csswg-drafts#6703 Bug: 1251374 Change-Id: I3ae227f9ca74ad09f29c0cc73e88bd7a5e4758e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206667 Reviewed-by: Kevin Ellis <kevers@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#929410}
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…alue for computed effect timing, a=testonly Automatic update from web-platform-tests Converted duration to return CSSNumericValue for computed effect timing When using a scroll timeline with an animation, calling getComputedTiming().duration on its effect will now return a CSSNumericValue containaning the computed percentage. This change brings our implementation in line with recent spec changes: w3c/csswg-drafts#6703 Bug: 1251374 Change-Id: I3ae227f9ca74ad09f29c0cc73e88bd7a5e4758e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206667 Reviewed-by: Kevin Ellis <kevers@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#929410} -- wpt-commits: 342effc0d1b4ac6012201175495d17a2718f8152 wpt-pr: 31126
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[web-animation-2] Include CSSNumberish as a valid type for EffectTiming duration
getComputedTiming resolves the iteration duration if specified as 'auto'. The resolved duration is CSSNumberish when the associated animation has a progress based timeline.