Skip to content

[web-animations-2][scroll-animations-1]Update timeline currentTime #6742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

kevers-google
Copy link
Contributor

[web-animations-2][scroll-animations-1]Update timeline currentTime

Timeline current time should be a percentage for progress-based animations.

@kevers-google
Copy link
Contributor Author

Scroll-animations-1 was referencing {{EffectTiming/duration}} instead of {{AnimationTimeline/duration}}. The former is incorrect since it is the duration if a single iteration. The "corrected link" did not properly resolve when tested locally, possibly because it is only mentioned in a partial idl in web-animations-2. What is the correct way to reference?

Copy link
Contributor

@flackr flackr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell that is the correct way to reference it. Perhaps web-animations-2 is not correctly exporting the definition.

@@ -838,12 +838,12 @@ The [=timeline/current time=] of a {{ScrollTimeline}} is calculated as follows:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

web-animations-2 wasn't in the linking database; fixed now

Copy link
Contributor Author

@kevers-google kevers-google Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed reference on line 361.

@kevers-google
Copy link
Contributor Author

Created a fresh PR as #8371.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants