[web-animations-2][scroll-animations-1]Update timeline currentTime #6742
Conversation
|
Scroll-animations-1 was referencing {{EffectTiming/duration}} instead of {{AnimationTimeline/duration}}. The former is incorrect since it is the duration if a single iteration. The "corrected link" did not properly resolve when tested locally, possibly because it is only mentioned in a partial idl in web-animations-2. What is the correct way to reference? |
flackr
left a comment
There was a problem hiding this comment.
As far as I can tell that is the correct way to reference it. Perhaps web-animations-2 is not correctly exporting the definition.
| <dl class="switch"> | ||
| : If |current scroll offset| is less than [=effective start offset=]: | ||
| :: The [=timeline/current time=] is 0. | ||
|
|
There was a problem hiding this comment.
There's another incorrect reference to EffectTiming/duration on line 361: https://github.com/w3c/csswg-drafts/pull/6742/files#diff-2c9a6f64531fbc8999f49d196d504641d843cb1e57a45650cd75b613958b17c9R361
There was a problem hiding this comment.
web-animations-2 wasn't in the linking database; fixed now
There was a problem hiding this comment.
Fixed reference on line 361.
|
Created a fresh PR as #8371. |
[web-animations-2][scroll-animations-1]Update timeline currentTime
Timeline current time should be a percentage for progress-based animations.