[css-animations-2] Account for animation-composition when merging keyframes (closes #6935)
#6974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eyframes (closes w3c#6935)
|
I have filed web-platform-tests/wpt#32495 with the relevant test changes. |
birtles
reviewed
Jan 22, 2022
birtles
approved these changes
Jan 22, 2022
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Jan 25, 2022
…sition https://bugs.webkit.org/show_bug.cgi?id=235596 Reviewed by Dean Jackson. LayoutTests/imported/w3c: Import test recently added in WPT via web-platform-tests/wpt#32495. We pass them all with the source change. * web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt: * web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative.html: Source/WebCore: The CSS Animations Level 2 spec recently changed to account for animation-composition when deduplicating @Keyframes rules (see w3c/csswg-drafts#6974). * animation/CompositeOperation.h: * style/StyleResolver.cpp: (WebCore::Style::Resolver::keyframeRulesForName const): Canonical link: https://commits.webkit.org/246394@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
annulen
pushed a commit
to qtwebkit/qtwebkit
that referenced
this pull request
Jan 26, 2022
…sition https://bugs.webkit.org/show_bug.cgi?id=235596 Reviewed by Dean Jackson. LayoutTests/imported/w3c: Import test recently added in WPT via web-platform-tests/wpt#32495. We pass them all with the source change. * web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt: * web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative.html: Source/WebCore: The CSS Animations Level 2 spec recently changed to account for animation-composition when deduplicating @Keyframes rules (see w3c/csswg-drafts#6974). * animation/CompositeOperation.h: * style/StyleResolver.cpp: (WebCore::Style::Resolver::keyframeRulesForName const): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@288571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyframes should only be merged when they have matching keyframe offset, timing function and composite.