[css-contain-3] Pseudo elements and shadow DOM #5984 #6711 #7019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per resolution for issues w3c#5984 and w3c#6711: w3c#5984 (comment) w3c#6711 (comment)
mirisuzanne
reviewed
Feb 7, 2022
css-contain-3/Overview.bs
Outdated
| the <a>shadow-including inclusive ancestors</a> of the <a>ultimate | ||
| originating element</a>. | ||
|
|
||
| It follows that: |
There was a problem hiding this comment.
This following section seems like it could be in a note, rather than part of the normative text?
css-contain-3/Overview.bs
Outdated
| past other elements for the purpose of inheritance and rendering | ||
| * Multiple pseudo elements do not allow pseudo elements to be query | ||
| containers for other pseudo elements. E.g., the host, but not the part() | ||
| can be the query container for ''::before'' in ''host::part()::before'' |
There was a problem hiding this comment.
The ''foo'' syntax is meant for auto-linking 'CSS definition types except property and descriptor'. I'm not sure if that includes the pseudo-elements above, but I don't think it includes example selectors. Probably better to use <code> in these cases?
There was a problem hiding this comment.
It works for the pseudo elements. I've left some as auto-linking, but <code> when it talks about parts of the example selector.
mirisuzanne
approved these changes
Feb 7, 2022
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 7, 2022
Pseudo element and shadow dom behavior resolved and spec changed[1]. [1] w3c/csswg-drafts#7019 Bug: 1269192, 1217976 Change-Id: Ie2b8ee1b35d7464581a53201c1b16d29c49baae4
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 7, 2022
Pseudo element and shadow dom behavior resolved and spec changed[1]. [1] w3c/csswg-drafts#7019 Bug: 1269192, 1217976 Change-Id: Ie2b8ee1b35d7464581a53201c1b16d29c49baae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440660 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#967991}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 7, 2022
Pseudo element and shadow dom behavior resolved and spec changed[1]. [1] w3c/csswg-drafts#7019 Bug: 1269192, 1217976 Change-Id: Ie2b8ee1b35d7464581a53201c1b16d29c49baae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440660 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#967991}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 7, 2022
Pseudo element and shadow dom behavior resolved and spec changed[1]. [1] w3c/csswg-drafts#7019 Bug: 1269192, 1217976 Change-Id: Ie2b8ee1b35d7464581a53201c1b16d29c49baae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440660 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#967991}
mattwoodrow
pushed a commit
to mattwoodrow/wpt
that referenced
this pull request
Feb 15, 2022
Pseudo element and shadow dom behavior resolved and spec changed[1]. [1] w3c/csswg-drafts#7019 Bug: 1269192, 1217976 Change-Id: Ie2b8ee1b35d7464581a53201c1b16d29c49baae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440660 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#967991}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 26, 2022
…ive, a=testonly Automatic update from web-platform-tests [@container] Make tentative tests normative Pseudo element and shadow dom behavior resolved and spec changed[1]. [1] w3c/csswg-drafts#7019 Bug: 1269192, 1217976 Change-Id: Ie2b8ee1b35d7464581a53201c1b16d29c49baae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440660 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#967991} -- wpt-commits: 974633788f17c1a1ecf963a9b4c0ea979da00aa8 wpt-pr: 32731
DanielRyanSmith
pushed a commit
to DanielRyanSmith/wpt
that referenced
this pull request
Feb 28, 2022
Pseudo element and shadow dom behavior resolved and spec changed[1]. [1] w3c/csswg-drafts#7019 Bug: 1269192, 1217976 Change-Id: Ie2b8ee1b35d7464581a53201c1b16d29c49baae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440660 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#967991}
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 1, 2022
…ive, a=testonly Automatic update from web-platform-tests [@container] Make tentative tests normative Pseudo element and shadow dom behavior resolved and spec changed[1]. [1] w3c/csswg-drafts#7019 Bug: 1269192, 1217976 Change-Id: Ie2b8ee1b35d7464581a53201c1b16d29c49baae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440660 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#967991} -- wpt-commits: 974633788f17c1a1ecf963a9b4c0ea979da00aa8 wpt-pr: 32731
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 8, 2022
…ive, a=testonly Automatic update from web-platform-tests [@container] Make tentative tests normative Pseudo element and shadow dom behavior resolved and spec changed[1]. [1] w3c/csswg-drafts#7019 Bug: 1269192, 1217976 Change-Id: Ie2b8ee1b35d7464581a53201c1b16d29c49baae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440660 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#967991} -- wpt-commits: 974633788f17c1a1ecf963a9b4c0ea979da00aa8 wpt-pr: 32731
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 8, 2022
…ive, a=testonly Automatic update from web-platform-tests [@container] Make tentative tests normative Pseudo element and shadow dom behavior resolved and spec changed[1]. [1] w3c/csswg-drafts#7019 Bug: 1269192, 1217976 Change-Id: Ie2b8ee1b35d7464581a53201c1b16d29c49baae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440660 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#967991} -- wpt-commits: 974633788f17c1a1ecf963a9b4c0ea979da00aa8 wpt-pr: 32731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per resolution for issues #5984 and #6711:
#5984 (comment)
#6711 (comment)
Test coverage:
https://wpt.live/css/css-contain/container-queries/pseudo-elements-001.html
https://wpt.live/css/css-contain/container-queries/pseudo-elements-002.tentative.html
https://wpt.live/css/css-contain/container-queries/pseudo-elements-003.tentative.html
https://wpt.live/css/css-contain/container-queries/container-for-shadow-dom.tentative.html