[css-flexbox-1] [css-grid-2] [css-ruby-1] Flag "New values" tables for display property as informative #7242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Via mdn/yari#4656 (comment) The CSS Display spec defines possible values for the `display` property. This includes `flex`, `grid`, `ruby` and associated values, whose meanings are normatively defined in CSS Flexbox, CSS Grid and CSS Ruby. On top of meanings, the CSS Flexbox, CSS Grid and CSS Ruby specs actually redefine the values themselves through a "New Values" table. This is fully clear for humans, but a naive attempt to extract formal value definitions from CSS specs ends up with the impression that `flex`, `grid` and `ruby` are actually defined twice. This update flags the "New values" tables in CSS Flexbox, CSS Grid and CSS Ruby as "informative" so that extraction tools can understand that the values themselves are actually defined in CSS Display. This does not introduce any visual change.
Ah, this should be considered a bug; I transfer attributes from other shorthands into the generated versions. The point this translation occurs in the code makes it slightly funky to do so (it's a textual transformation, preceding DOM parsing), but not too bad. (But happy to merge this as-is for now, rather than waiting for me to do a fix.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via mdn/yari#4656 (comment)
The CSS Display spec defines possible values for the
displayproperty. This includesflex,grid,rubyand associated values, whose meanings are normatively defined in CSS Flexbox, CSS Grid and CSS Ruby.On top of meanings, the CSS Flexbox, CSS Grid and CSS Ruby specs actually redefine the values themselves through a "New Values" table. This is fully clear for humans, but a naive attempt to extract formal value definitions from CSS specs ends up with the impression that
flex,gridandrubyare actually normatively defined twice.This update proposes to flag the "New values" tables in CSS Flexbox, CSS Grid and CSS Ruby as "informative" so that extraction tools can understand that the values themselves are actually defined in CSS Display. This does not introduce any visual change.
(Note the "informative" class cannot be added to the
<pre>tag directly as Bikeshed does not preserve the class when it generates the spec)