Skip to content

[css-overflow-3] Fix simple grammatical error. #7277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

dlrobertson
Copy link
Member

Some (hopefully helpful) grammatical fixes after some initial reading.

Copy link
Member Author

@dlrobertson dlrobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some things I noted on an initial read. Please let me know if I missed something.

@@ -278,7 +278,7 @@ Scrollable Overflow</h3>
in the inline axis if 'align-content'
is ''justify-content/normal''.

Note: It's hoped that including including inline-axis padding here is Web-compatible
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed like an accidental additional include.

prior to any user or programmatic scrolling that changes it,
prior to any user or programmatic scrolling that changes it.

The <a>initial scroll position</a>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run on sentence. Broken up into a definition and then another sentence on writing mode.

@w3cbot
Copy link

w3cbot commented May 16, 2022

svgeesus marked as non substantive for IPR from ash-nazg.

Copy link
Member

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this got lost.

It largely looks good, but I think the introduction of a paragraph break was undesirable, so I've added a change to remove that.

@dbaron dbaron merged commit d82b2c9 into w3c:main Oct 6, 2022
@dlrobertson
Copy link
Member Author

Sorry this got lost.

No problem! Thanks for the paragraph break fix.

@dlrobertson dlrobertson deleted the grammar_fixes branch October 6, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants