-
Notifications
You must be signed in to change notification settings - Fork 715
[css-overflow-3] Fix simple grammatical error. #7277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some things I noted on an initial read. Please let me know if I missed something.
css-overflow-3/Overview.bs
Outdated
@@ -278,7 +278,7 @@ Scrollable Overflow</h3> | |||
in the inline axis if 'align-content' | |||
is ''justify-content/normal''. | |||
|
|||
Note: It's hoped that including including inline-axis padding here is Web-compatible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seemed like an accidental additional include
.
prior to any user or programmatic scrolling that changes it, | ||
prior to any user or programmatic scrolling that changes it. | ||
|
||
The <a>initial scroll position</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run on sentence. Broken up into a definition and then another sentence on writing mode.
svgeesus marked as non substantive for IPR from ash-nazg. |
a424e96
to
9f8b3d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this got lost.
It largely looks good, but I think the introduction of a paragraph break was undesirable, so I've added a change to remove that.
No problem! Thanks for the paragraph break fix. |
Some (hopefully helpful) grammatical fixes after some initial reading.