[css-overflow-3] Fix simple grammatical error. #7277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlrobertson
commented
May 16, 2022
Member
Author
dlrobertson
left a comment
There was a problem hiding this comment.
Just some things I noted on an initial read. Please let me know if I missed something.
css-overflow-3/Overview.bs
Outdated
| in the inline axis if 'align-content' | ||
| is ''justify-content/normal''. | ||
|
|
||
| Note: It's hoped that including including inline-axis padding here is Web-compatible |
Member
Author
There was a problem hiding this comment.
This seemed like an accidental additional include.
| prior to any user or programmatic scrolling that changes it, | ||
| prior to any user or programmatic scrolling that changes it. | ||
|
|
||
| The <a>initial scroll position</a> |
Member
Author
There was a problem hiding this comment.
Run on sentence. Broken up into a definition and then another sentence on writing mode.
|
svgeesus marked as non substantive for IPR from ash-nazg. |
a424e96 to
9f8b3d1
Compare
dbaron
approved these changes
Oct 6, 2022
Member
dbaron
left a comment
There was a problem hiding this comment.
Sorry this got lost.
It largely looks good, but I think the introduction of a paragraph break was undesirable, so I've added a change to remove that.
Member
Author
No problem! Thanks for the paragraph break fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some (hopefully helpful) grammatical fixes after some initial reading.