[css-contain-3] Improve CSSContainerRule #7293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Probably needs a resolution on #7190 before merging. |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 26, 2022
This implements w3c/csswg-drafts#7293, pending a spec resolution, so landing test as tentative for now, but the change makes sense. Differential Revision: https://phabricator.services.mozilla.com/D155602
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 31, 2022
This implements w3c/csswg-drafts#7293, pending a spec resolution, so landing test as tentative for now, but the change makes sense. Differential Revision: https://phabricator.services.mozilla.com/D155602 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1787173 gecko-commit: 0a2ff7dadf29a1a30e5a824e50a019118486632e gecko-reviewers: nchevobbe
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 31, 2022
This implements w3c/csswg-drafts#7293, pending a spec resolution, so landing test as tentative for now, but the change makes sense. Differential Revision: https://phabricator.services.mozilla.com/D155602 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1787173 gecko-commit: 0a2ff7dadf29a1a30e5a824e50a019118486632e gecko-reviewers: nchevobbe
mirisuzanne
approved these changes
Sep 7, 2022
|
@andruud can you resolve the conflicts here, and we can get this merged? |
- Add containerName, containerQuery. - Reorganize syntax so that conditionText and containerQuery both map to productions which make sense.
|
Done. |
mirisuzanne
approved these changes
Sep 8, 2022
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 13, 2023
To be compliant with w3c/csswg-drafts#7293. Also adding some tests to test the container name serialisation. Fixed: 1393577 Change-Id: I062eef71d1c004d7539a775fa873ac433ed24d79
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 13, 2023
To be compliant with w3c/csswg-drafts#7293. Also adding some tests to test the container name serialisation. Fixed: 1393577 Change-Id: I062eef71d1c004d7539a775fa873ac433ed24d79
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 13, 2023
[@container] Add containerName and containerQuery, update conditionText. To be compliant with w3c/csswg-drafts#7293. Also adding some tests to test the container name serialisation. Fixed: 1393577 Change-Id: I062eef71d1c004d7539a775fa873ac433ed24d79
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 24, 2023
To be compliant with w3c/csswg-drafts#7293. Also adding some tests to test the container name serialisation. Fixed: 1393577 Change-Id: I062eef71d1c004d7539a775fa873ac433ed24d79
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 24, 2023
To be compliant with w3c/csswg-drafts#7293. Also adding some tests to test the container name serialisation. Fixed: 1393577 Change-Id: I062eef71d1c004d7539a775fa873ac433ed24d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4161450 Commit-Queue: Daniil Sakhapov <sakhapov@google.com> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1096448}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 24, 2023
To be compliant with w3c/csswg-drafts#7293. Also adding some tests to test the container name serialisation. Fixed: 1393577 Change-Id: I062eef71d1c004d7539a775fa873ac433ed24d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4161450 Commit-Queue: Daniil Sakhapov <sakhapov@google.com> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1096448}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 24, 2023
To be compliant with w3c/csswg-drafts#7293. Also adding some tests to test the container name serialisation. Fixed: 1393577 Change-Id: I062eef71d1c004d7539a775fa873ac433ed24d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4161450 Commit-Queue: Daniil Sakhapov <sakhapov@google.com> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1096448}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 1, 2023
…inerQuery, update conditionText., a=testonly Automatic update from web-platform-tests [@container] Add containerName and containerQuery, update conditionText. To be compliant with w3c/csswg-drafts#7293. Also adding some tests to test the container name serialisation. Fixed: 1393577 Change-Id: I062eef71d1c004d7539a775fa873ac433ed24d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4161450 Commit-Queue: Daniil Sakhapov <sakhapov@google.com> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1096448} -- wpt-commits: 84aa541e5ad5db22bc619e1002d6c90fa875d743 wpt-pr: 37930
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Feb 3, 2023
…inerQuery, update conditionText., a=testonly Automatic update from web-platform-tests [@container] Add containerName and containerQuery, update conditionText. To be compliant with w3c/csswg-drafts#7293. Also adding some tests to test the container name serialisation. Fixed: 1393577 Change-Id: I062eef71d1c004d7539a775fa873ac433ed24d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4161450 Commit-Queue: Daniil Sakhapov <sakhapov@google.com> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1096448} -- wpt-commits: 84aa541e5ad5db22bc619e1002d6c90fa875d743 wpt-pr: 37930
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 28, 2023
To be compliant with w3c/csswg-drafts#7293. Also adding some tests to test the container name serialisation. Fixed: 1393577 Change-Id: I062eef71d1c004d7539a775fa873ac433ed24d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4161450 Commit-Queue: Daniil Sakhapov <sakhapov@google.com> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1096448}
Loirooriol
pushed a commit
to Loirooriol/servo
that referenced
this pull request
Oct 30, 2023
This implements w3c/csswg-drafts#7293, pending a spec resolution, so landing test as tentative for now, but the change makes sense. Differential Revision: https://phabricator.services.mozilla.com/D155602
mrobinson
pushed a commit
to Loirooriol/servo
that referenced
this pull request
Nov 2, 2023
This implements w3c/csswg-drafts#7293, pending a spec resolution, so landing test as tentative for now, but the change makes sense. Differential Revision: https://phabricator.services.mozilla.com/D155602
mrobinson
pushed a commit
to Loirooriol/servo
that referenced
this pull request
Nov 3, 2023
This implements w3c/csswg-drafts#7293, pending a spec resolution, so landing test as tentative for now, but the change makes sense. Differential Revision: https://phabricator.services.mozilla.com/D155602
mrobinson
pushed a commit
to servo/servo
that referenced
this pull request
Nov 3, 2023
This implements w3c/csswg-drafts#7293, pending a spec resolution, so landing test as tentative for now, but the change makes sense. Differential Revision: https://phabricator.services.mozilla.com/D155602
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jun 1, 2024
…inerQuery, update conditionText., a=testonly Automatic update from web-platform-tests [@container] Add containerName and containerQuery, update conditionText. To be compliant with w3c/csswg-drafts#7293. Also adding some tests to test the container name serialisation. Fixed: 1393577 Change-Id: I062eef71d1c004d7539a775fa873ac433ed24d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4161450 Commit-Queue: Daniil Sakhapov <sakhapov@google.com> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1096448} -- wpt-commits: 84aa541e5ad5db22bc619e1002d6c90fa875d743 wpt-pr: 37930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to productions which make sense.
#7033