Skip to content

Conversation

@andruud
Copy link
Member

@andruud andruud commented May 23, 2022

  • Make 'fictional tag sequence' link to something.
  • Use 'ident sequence', not 'identifier'.
  • Remove references to <<size-query>>, as that no longer exists, and:
  • Also remove references to <<style-query>>, to be consistent.
  • '@container/orientation' instead of 'orientation'.
  • Link to <<'container-type'>> instead of the now non-existent
    <<container-type>>.

@andruud andruud requested a review from mirisuzanne May 23, 2022 09:13
Copy link
Member

@tabatkins tabatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two ident changes need to be changed to refer to a CSS Values concept, not a CSS Syntax concept, but the rest look good.

 - Make 'fictional tag sequence' link to something.
 - Use 'identifier' from css-values, not css-syntax.
 - Remove references to <<size-query>>, as that no longer exists, and:
 - Also remove references to <<style-query>>, to be consistent.
 - '@container/orientation' instead of 'orientation'.
 - Link to <<'container-type'>> instead of the now non-existent
   <<container-type>.
@andruud andruud force-pushed the contain3_relink branch from 295b9df to 0d281aa Compare May 25, 2022 06:57
@andruud andruud requested a review from tabatkins May 25, 2022 07:01
@andruud
Copy link
Member Author

andruud commented Jun 9, 2022

@tabatkins Happy with this now?

@tabatkins tabatkins merged commit b4f77f5 into w3c:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants