Skip to content

[css-fonts-3] Fix the mistake that the scheme is inconsistent, and improve comments #7337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2022
Merged

Conversation

sxyazi
Copy link
Contributor

@sxyazi sxyazi commented Jun 5, 2022

Examples of different schemas and different domains are inconsistent with the given assumed URL.

@w3cbot
Copy link

w3cbot commented Jun 5, 2022

sxyazi marked as non substantive for IPR from ash-nazg.

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since example.x is unresolvable, the use of http or https is irrelevant.

I don't see the changes in the comments as being worthwhile, sorry.

@svgeesus svgeesus closed this Jun 5, 2022
@sxyazi
Copy link
Contributor Author

sxyazi commented Jun 5, 2022

@svgeesus Hi, I think the inconsistent URLs in the examples would confuse the reader (at least for me), and besides it makes no sense to load HTTP resources on an HTTPS page, the security policy would prevent it. Is this aspect of rigor worth considering?

img

@tabatkins tabatkins reopened this Jun 17, 2022
@tabatkins
Copy link
Member

This is actually legit, since the example straight up doesn't make sense right now - it's claiming an https url is "different scheme" from the main url, which is also https. It looks like someone just hit one of the urls with a regex at some point, or maybe just hypercorrected out of reflex?

Regardless, either the example base url needs to be switched back to http, or the font urls listed below it need to have their schemes swapped to match the comments.

@svgeesus
Copy link
Contributor

Dug into the history a bit and yes, originally example.com/page.html was http not https.

Agree that changing this back to http, as the PR does, is the simplest.

@w3cbot
Copy link

w3cbot commented Jun 18, 2022

svgeesus marked as non substantive for IPR from ash-nazg.

@svgeesus svgeesus merged commit 819fdbd into w3c:main Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants