Skip to content

Conversation

@scientificware
Copy link
Contributor

I suspect typos in example 4 and example 26.

[css-spec-shortname-1] Brief description which should also include the #issuenum-or-URL and/or link to relevant CSSWG minutes.

Copy the above line into the Title and replace with the relevant details. Fill in any additional details here. See https://github.com/w3c/csswg-drafts/blob/master/CONTRIBUTING.md for more info.

I suspect typos in example 4 and example 26.
@dbaron
Copy link
Member

dbaron commented Aug 12, 2022

I think the second of these two edits would be better left the way it is now; "a lime green" is better than "a lime". The first edit is probably OK either way.

@w3cbot
Copy link

w3cbot commented Aug 12, 2022

dbaron marked as non substantive for IPR from ash-nazg.

@scientificware
Copy link
Contributor Author

scientificware commented Aug 12, 2022

Thanks @dbaron,
Yes you are right, but it's a bit ambiguous.
Maybe we could we consider a "lime" color.

This suggestion respect all other references about the "lime" color.
Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First edit is good, second edit (a "lime" color) is worse and should be left as-is

@svgeesus
Copy link
Contributor

Yes you are right, but it's a bit ambiguous.

Not at all. lime is a named color; "a lime green" is a description of a class of colors.

image

@scientificware
Copy link
Contributor Author

scientificware commented Aug 14, 2022

@svgeesus I presume you are talking about example 26.

I think, I understand what you mean.
I was confused because "limegreen" is also a color name.
And there are no other references on class names in the document.
The purpose of this example is just to encode the same color. So why associate a class name?
Sorry for insisting.

Thanks for your review.

Regards.

@svgeesus
Copy link
Contributor

Class as in "category", not class as in "the class attribute".

@svgeesus
Copy link
Contributor

I presume you are talking about example 26

Example 26 is about srgb-linear. I assume you mean example 11 which is the one affected by your first commit?

@svgeesus svgeesus merged commit 91b4358 into w3c:main Aug 15, 2022
@scientificware
Copy link
Contributor Author

@svgeesus really sorry, I was wrong, it was example 9.
Thanks for approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants