-
Notifications
You must be signed in to change notification settings - Fork 756
[scroll-animations-1] Make view-timeline take a list of singles #7694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
scroll-animations-1/Overview.bs
Outdated
| <pre class='propdef'> | ||
| Name: view-timeline-name | ||
| Value: none | <<custom-ident>># | ||
| Value: none | <<single-timeline-name>># |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think none needs to be inside the list, otherwise it's not possible to represent the following as a shorthand: view-timeline-axis:block,inline; view-timeline-name:none.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, disregard that, we can't represent different-length longhands as a shorthand anyway ...
Current grammar has two comma-separated lists inside an outer comma- separated list. This means specifying two timelines would look like "timeline1, timeline2, inline, block", which obviously isn't what we want. Instead we should follow how the 'animation' shorthand works, and let the outer comma-separated list take space-separated single items: "timeline1 inline, timeline2 block".
751fb6c to
ae23192
Compare
| <pre class='propdef shorthand'> | ||
| Name: view-timeline | ||
| Value: [ <<'view-timeline-name'>> || <<'view-timeline-axis'>> ]# | ||
| Value: [ <<single-timeline-name>> || <<single-timeline-axis>> ]# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or <single-timeline># with <single-timeline> = <single-timeline-name> || <single-timeline-axis> if you want to align with animations/background/etc.
|
This is actually not necessary, see the definition of |
|
Aha, I didn't know about that ... |
|
@fantasai Actually, no. https://www.w3.org/TR/css-values-4/#component-types does not appy, because the |
Current grammar has two comma-separated lists inside an outer comma-
separated list. This means specifying two timelines would look like
"timeline1, timeline2, inline, block", which obviously isn't what we want.
Instead we should follow how the 'animation' shorthand works, and let
the outer comma-separated list take space-separated single items:
"timeline1 inline, timeline2 block".