[css-conditional-5] Add explainer for font-tech(),font-format() Conditionals Syntax
#7713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparation for Blink Intent-to-ship.
Collaborator
Author
font-tech(),font-format() Conditionals Syntaxfont-tech(),font-format() Conditionals Syntax
dbaron
reviewed
Sep 8, 2022
svgeesus
reviewed
Sep 9, 2022
Contributor
svgeesus
left a comment
There was a problem hiding this comment.
Overall nicely done. I agree with the points David made and added a few more.
Contributor
For myself yes, and thank you for kicking off writing this. |
svgeesus
requested changes
Sep 14, 2022
Collaborator
Author
|
Thank you both for the thorough review and good suggestions. Hopefully all comments addressed, please take another look. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for Blink Intent-to-ship.