Fix the auto-builder redirect pages to maintain the URL fragment #7801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the https://w3c.github.io/csswg-drafts/ mirror, if you append a spec's shortname without a level to the URL (https://w3c.github.io/csswg-drafts/css-grid, for example), you land on a page that redirects you to the current work of that spec. However, if you add a fragment to the URL, that fragment goes away in the redirect. This is an issue for MDN, for example. The fragment goes away because currently redirects happen with meta refresh. This change uses `<noscript>` to make sure such redirects keep working when scripting is disabled, and then does a JS-based redirect that does preserve the fragment.
Member
Author
|
@tabatkins PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the https://w3c.github.io/csswg-drafts/ mirror, if you append a spec's shortname without a level to the URL (https://w3c.github.io/csswg-drafts/css-grid, for example), you land on a page that redirects you to the current work of that spec. However, if you add a fragment to the URL, that fragment goes away in the redirect. This is an issue for MDN, for example.
The fragment goes away because currently redirects happen with meta refresh. This change uses
<noscript>to make sure such redirects keep working when scripting is disabled, and then does a JS-based redirect that does preserve the fragment.