Skip to content

Clarify checking for active animations #7857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2022
Merged

Clarify checking for active animations #7857

merged 2 commits into from
Oct 11, 2022

Conversation

@khushalsagar
Copy link
Member

@khushalsagar khushalsagar commented Oct 7, 2022

[css-view-transitions-1] Clarify checking for active animations.

See discussion at #7785

@khushalsagar khushalsagar requested a review from birtles October 7, 2022 18:28
@khushalsagar khushalsagar mentioned this pull request Oct 7, 2022
Closed
birtles
birtles approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@birtles birtles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with the suggested change applied

@khushalsagar khushalsagar merged commit 29d5056 into main Oct 11, 2022
@plinss plinss deleted the active-animation branch October 22, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birtles birtles birtles approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khushalsagar @birtles