[css-animations-1] Define indexed property getter for CSSKeyframesRule #7887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tabatkins @dbaron Any chance I could get your review on this? Thanks! |
Contributor
Author
|
I've waited for over a month for review here so I might just go ahead and merge it. |
Contributor
|
Post-merge LGTM. |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 19, 2024
For CSSKeyframesRule, getter and length was updated in the spec [1]. In Blink, getter had been already defined. According to the WebIDL spec [2], interfaces that support indexed properties must define an integer-typed attribute named "length". This changes getter and exposes length attribute following the spec [3] [1] w3c/csswg-drafts#7887 [2] https://webidl.spec.whatwg.org/#idl-indexed-properties [3] https://drafts.csswg.org/css-animations/#interface-csskeyframesrule-id Bug: 1502758 Change-Id: I12bfebe39bf4fc87e04ddc5257c75b5ee7ed15e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5069356 Commit-Queue: Euisang Lim <eui-sang.lim@samsung.com> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262337}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7684