[css-view-transitions-1] Skip transition if viewport changes. Fixes #8045 #8306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -806,6 +814,9 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn; | |||
|
|
|||
| Note: This happens if |transition| was [=skip the view transition|skipped=] before this point. | |||
|
|
|||
| 1. If |transition|'s [=ViewTransition/initial snapshot viewport size=] is not equal to the [=snapshot viewport size=], | |||
There was a problem hiding this comment.
Not sure if we need to specify exact when we do this check, or we can just add it to the step that's setting it:
1. Set |transition|'s [=ViewTransition/initial snapshot viewport size=] to the [=snapshot viewport size=]. If this size changes after this point, skip the transition.
I'm fine with this too.
There was a problem hiding this comment.
I thought about this, but doing it properly would be more complicated.
Changes to the snapshot viewport happen outside the page, so to do things on the page, it would need to queue a task. Because a task is queued, we can't guarantee the same view transition is active compared to when the task was queued, so that will need to be verified before skipping the transition.
khushalsagar
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.