You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current syntax makes the color stop list optional, which is obviously unexpected.
This PR also aligns CSS Images 4 with CSS Images 3 regarding <size> renamed to <rg-size> (resolving a conflict with <ray()>) and <ending-shape> renamed to <rg-ending-shape> (for consistency, I guess).
I am not sure if a? b? || c is different than [a? b?]! || c so I prefered the first option for simplicity.
Right, and actually I would have preferred the other syntax for two reasons.
First, the trailing ? in (conic gradient parameters) [[[from <angle>]? [at <position>]?] || <color-interpolation-method>]? and (radial gradient parameters) [[[<radial-shape> || <radial-size>]? [at <position>]?] || <color-interpolation-method>]? is useless, which does not seem right to me.
Second, the result is not consistent with the result from parsing <linear-gradient()>.
conic-gradient(red, cyan), linear-gradient(red, cyan), radial-gradient(red, cyan), produce the following pseudo-representations:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7986.
The current syntax makes the color stop list optional, which is obviously unexpected.
This PR also aligns CSS Images 4 with CSS Images 3 regarding
<size>renamed to<rg-size>(resolving a conflict with<ray()>) and<ending-shape>renamed to<rg-ending-shape>(for consistency, I guess).I am not sure if
a? b? || cis different than[a? b?]! || cso I prefered the first option for simplicity.