[css-contain-2] rename ContentVisibilityAutoStateChanged to ContentVisibilityAutoStateChange
#8413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tVisibilityAutoStateChange` Per #7603 (comment) the group resolved to use present tense for the event and interface. Since then, Mozilla and Chrome both implemented the interface under the new name. https://hg.mozilla.org/mozilla-central/rev/6095dabf5574 https://chromium.googlesource.com/chromium/src/+/9851571ecb54c47a205b2321006577b9799c0ea3 This updates both the event name and interface to reflect the resolution and to match implementation.
45d941a to
35e894e
Compare
8d7c4a8 to
45d941a
Compare
45d941a to
8d7c4a8
Compare
Member
|
Can someone please review and merge or close this PR? This is one of those that play havoc with the mercurial conversion (due to the force push getting the hashes out of sync). @myakura In the future, please fork the repo and create your branches and PRs from your private fork instead of in the main repo. Thanks. |
Member
|
Merged, I expect the only reason it wasn't was because of the IPR issue. I thought we were killing the mercurial bridge, fwiw? |
myakura
added a commit
to myakura/mdn-content
that referenced
this pull request
Feb 18, 2023
CSSWG updated the draft and had the new URL for the event and corresponding definitions. w3c/csswg-drafts#8413 Signed-off-by: Masataka Yakura <masataka.yakura@gmail.com>
myakura
added a commit
to myakura/browser-compat-data
that referenced
this pull request
Feb 18, 2023
…r to W3C specs mirror on GitHub Pages The CSSWG updaed the css-contain-2 editors' draft to incorporate name change I raised in mdn#18847 w3c/csswg-drafts#8413 The TR/contain-2 version updates less than Editors' drafts on GH. So I switched to the GH Pages link.
teoli2003
added a commit
to mdn/content
that referenced
this pull request
Feb 18, 2023
* update link to cotentvisibilityautostatechangeevent spec CSSWG updated the draft and had the new URL for the event and corresponding definitions. w3c/csswg-drafts#8413 Signed-off-by: Masataka Yakura <masataka.yakura@gmail.com> * Remove useless spec link in the prose --------- Signed-off-by: Masataka Yakura <masataka.yakura@gmail.com> Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
teoli2003
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Feb 18, 2023
…r to W3C specs mirror on GitHub Pages (#18950) * update spec link for `contentvisibilityautostatechange` event to refer to W3C specs mirror on GitHub Pages The CSSWG updaed the css-contain-2 editors' draft to incorporate name change I raised in #18847 w3c/csswg-drafts#8413 The TR/contain-2 version updates less than Editors' drafts on GH. So I switched to the GH Pages link. * fix speclink to the `ContentVisibilityAutoStateChangeEvent` ctor.
pmeenan
pushed a commit
to pmeenan/content
that referenced
this pull request
Feb 19, 2023
* update link to cotentvisibilityautostatechangeevent spec CSSWG updated the draft and had the new URL for the event and corresponding definitions. w3c/csswg-drafts#8413 Signed-off-by: Masataka Yakura <masataka.yakura@gmail.com> * Remove useless spec link in the prose --------- Signed-off-by: Masataka Yakura <masataka.yakura@gmail.com> Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #7603 (comment) the group resolved to use present tense for the event and interface.
Since then, Mozilla and Chrome both implemented the interface under the new name.
https://hg.mozilla.org/mozilla-central/rev/6095dabf5574
https://chromium.googlesource.com/chromium/src/+/9851571ecb54c47a205b2321006577b9799c0ea3
This updates both the event name and interface to reflect the resolution and to match implementation.