-
Notifications
You must be signed in to change notification settings - Fork 711
[css-cascade-6] Add implicit scopes #8463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mirisuzanne Please have a look. I felt that I had to reorganize a bit here to make a natural place for "implicit" scopes to live. Description of changes:
Hopefully it's more or less to your liking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andruud I think it's a big improvement, thanks. I suggested a change to the syntax production, allowing lower boundaries when the root is implicit. Otherwise, it looks good to me.
using the [=scoping root=] as the '':scope'' element, then | ||
* Set those elements as the [=scoping limits=]. | ||
|
||
[=Pseudo-elements=] cannot be [=scoping roots=] or [=scoping limits=]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After moving this above in the previous PR, I moved it back down! 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-)
Resolves #6606 #7349