-
Notifications
You must be signed in to change notification settings - Fork 717
[scroll-animations-1] Add self keyword #8471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to define what happens when the element's own box isn't a [=scroll container=].
Also you need to specify [=principal box=]. Some elements have multiple boxes.
Thanks for the feedback @fantasai; greatly appreciate it. Did some changes which should address your remarks. Happy to take more pointers, as this is all fairly new to me. |
Looks pretty good! The one other thing to fix is the line breaks. |
Interesting link. Makes sense, instead of cutting off mid-sentence when the line length limit is almost reached. Think I got it right now. |
I would have thought these cases are covered by the text in the ScrollTimeline interface:
Do we define this for scroll-timeline-name as well since that can target a non scroll container? |
078f25f
to
e085c9b
Compare
Co-authored-by: fantasai <fantasai.bugs@inkedblade.net>
@fantasai I’ve committed the suggested change. |
Fixes #8227.
This PR replaces #8390 which was created from the wrong branch.