Skip to content

[scroll-animations-1] source is updated upon request and in sync with currentTime #8541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

fantasai
Copy link
Collaborator

@fantasai fantasai commented Mar 7, 2023

See #8204

Copy link
Contributor

@flackr flackr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, but in the original issue you had also assumed that we minted a new scrolltimeline each time the subject changed #8204 (comment) and we decided in the discussion that it was not a new one and had an identity consistent with animation creation. Does this also need to be clarified?

@flackr
Copy link
Contributor

flackr commented Mar 10, 2023

Here's the relevant text from the css-animations spec:
https://drafts.csswg.org/css-animations/#interface-animationevent:~:text=If%20a%20match%20is%20found%2C%20the%20existing%20animation%20is%20updated

Changes to the animation-name update existing animations by iterating over the new list of animations from last to first, and, for each animation, finding the last matching animation in the list of existing animations. If a match is found, the existing animation is updated using the animation properties corresponding to its position in the new list of animations, whilst maintaining its current playback time as described above.

@flackr
Copy link
Contributor

flackr commented Mar 10, 2023

Oh n/m I didn't catch that you committed the identity thing separately. This looks good.

@flackr flackr merged commit ef7d13e into w3c:main Mar 10, 2023
@fantasai fantasai deleted the source-update branch March 21, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants