Skip to content

[css-backgrounds-4] Fixed and added definitions for box-shadow-offset: none #8605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[css-backgrounds-4] Fixed and added definitions for box-shadow-offset: none #8605

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e1d474
[css-backgrounds-4] Fixed and added definitions for box-shadow-offset…
SebastianZ Mar 16, 2023
e705bb4
[css-backgrounds-4] Fixed 'box-shadow' shorthand definition
SebastianZ Mar 18, 2023
a00eeb3
[css-backgrounds-4] Let 'box-shadow-offset: none' be animated as blan…
SebastianZ Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions css-backgrounds-4/Overview.bs
View file
Open in desktop
Copy link
Contributor

@Loirooriol Loirooriol Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

box-shadow should also change to "Computed value: see individual properties".

BTW, "Animation type" should also be "see individual properties", and the animation logic should go to the right property, but I guess that depends on #8592.

Copy link
Contributor Author

@SebastianZ SebastianZ Mar 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the computed value and removed the now incorrect note for "Animatable" about "treating none as a zero-item list".

I kept the animation logic at the shorthand for now and will fix it in the patch for #8592.

I also kept "Animatable" for now and replace it in another patch by "Animation type" as it's unrelated to this one.

Original file line number Diff line number Diff line change
Expand Up @@ -768,16 +768,24 @@ Initial: none
Applies to: all elements
Inherited: no
Percentages: N/A
Computed value: either 'none' or a list,
each item a pair of offsets (horizontal and vertical) from the element‘s box
Computed value: list, each item either 'none' or a pair of offsets
(horizontal and vertical) from the element‘s box
Animation type: by computed value
</pre>

<p>The 'box-shadow-offset' property defines one or more drop shadow offsets.
The property accepts a comma-separated list of horizontal and vertical offset pairs,
The property accepts a comma-separated list.
Each item in that list can either be the ''box-shadow-offset/none'' value,
which indicates no shadow, or a pair of horizontal and vertical offsets,
where both values are described as <<length>> values.

<dl>
<dt><dfn id="shadow-offset-none">none</dfn>
<dd>
No box shadow will be created.
Any other box shadow properties specified for this box shadow have no
effect.

<dt><dfn id="shadow-offset-x">1st <<length>></dfn>
<dd>
Specifies the <dfn>horizontal offset</dfn> of the shadow.
Expand Down Expand Up @@ -892,15 +900,13 @@ Initial: none
Applies to: all elements
Inherited: no
Percentages: N/A
Computed value: either the keyword ''box-shadow-offset/none'' or
a list, each item consisting of four absolute lengths
plus a computed color and optionally also a ''box-shadow-position/inset'' keyword
Computed value: see individual properties
Animation type: by computed value,
treating ''box-shadow-offset/none'' as a zero-item list
and appending blank shadows (''transparent 0 0 0 0'')
with a corresponding ''box-shadow-position/inset'' keyword as needed
to match the longer list
if the shorter list is otherwise compatible with the longer one
letting ''box-shadow-offset/none'' create a blank shadow
(''transparent 0 0 0 0'') when interpolated with non-'none' values
and appending blank shadows with a corresponding
''box-shadow-position/inset'' keyword as needed to match the longer list
if the shorter list is otherwise compatible with the longer one
</pre>

<p>The 'box-shadow' property attaches one or more drop-shadows to the box.
Expand Down