[css-images-4] Fixed interpolation of stripes() with different types
#8614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loirooriol
reviewed
Mar 19, 2023
css-images-4/Overview.bs
Outdated
| @@ -2420,7 +2420,8 @@ Interpolating ''stripes()'' {#interpolating-stripes} | |||
|
|
|||
| 1. Both the starting and ending image must have the same number of <<color-stripe>>s. | |||
|
|
|||
| 2. Neither image uses a combination of <<length>>, <<percentage>>, and <<flex>> stripes. | |||
| 2. Each pair of interpolated thicknesses must be of the same type, | |||
| i.e. both must either be of type <<length>, <<percentage>>, or <<flex>>. | |||
There was a problem hiding this comment.
Missing > in <<length>.
And the grammar uses <length-percentage> | <flex>, so it should probably be
Suggested change
| i.e. both must either be of type <<length>, <<percentage>>, or <<flex>>. | |
| i.e. both must either be of type <<length-percentage>> or <<flex>>. |
(which implies that lengths and percentages can be mixed).
There was a problem hiding this comment.
Changed. And as noted, I'll open a new issue to discuss mixing all values.
bff8263 to
c34dc21
Compare
Loirooriol
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the interpolation of
stripes()values to look at each pair of thicknesses instead of disallowing mixing values completely.This fixes #8163.
Sebastian