[scroll-animations-1] Update explainer to use new API and concepts.#8641
Merged
Conversation
kevers-google
suggested changes
Mar 24, 2023
Contributor
kevers-google
left a comment
There was a problem hiding this comment.
A few of the examples are still using 'enter" instead of "entry'.
Contributor
Author
Thanks, updated all of the enter references to entry. |
kevers-google
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scroll-animations-1 explainer had gotten fairly out of date after the most recent declarative rethinking and subsequent rewrite of the spec. This brings the concepts and examples in the explainer up to date, though further refinement could be done to focus more on the CSS side of things.