[scroll-animations-1] Add note about horizontal and vertical axis still using logical direction #8667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll following writing direction.
Contributor
|
For me, in general, this follows expected behavior, so a general SGTM. |
Contributor
Author
|
@fantasai, does this seem reasonable to add? |
fantasai
requested changes
Apr 14, 2023
Collaborator
fantasai
left a comment
There was a problem hiding this comment.
- s/may/can/ since we're not granting RFC2119 permission here. :)
- Move the note up to right after the DL, since it's a user-facing note clarifying the stuff in the DL and the following two paragraphs are rather less interesting to users.
- This brings up an interesting question about how we measure progress for
align-content: end...
fantasai
reviewed
Apr 14, 2023
Co-authored-by: fantasai <fantasai.bugs@inkedblade.net>
Contributor
Author
|
Thanks for the review, I like your edit and moved the note just after the dl as suggested. |
fantasai
approved these changes
Apr 24, 2023
Collaborator
fantasai
left a comment
There was a problem hiding this comment.
Wfm, but I think you need to rebase over the latest spec. :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8665