[cssom] Don't serialize shorthand if importance differs #870
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the following declarations:
the current spec should return something for
getPropertyValue('background'), but all browsers (even Servo) agree on that this should return nothing because the importance of its longhands differ.This PR fixes this issue.
It can alternatively be fixed in "serialize a CSS value" algorithm. Given that the other callsite of this algorithm with a list (which is "serialize a CSS declaration block") already handles important flag itself, I guess it is better being put in
getPropertyValuerather than "serialize a CSS value".