[scroll-animations-1] Also rerun style/layout for changed timeline ranges #8704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevers-google
approved these changes
Apr 13, 2023
fantasai
reviewed
Apr 14, 2023
Co-authored-by: fantasai <fantasai.bugs@inkedblade.net>
andruud
reviewed
Apr 19, 2023
| we run and we run an additional step to recalculate styles and update layout. | ||
| As we only gather stale timelines during the first style and layout calculation, | ||
|
|
||
| Note: We check for layout changes after dispatching any {{ResizeObserver}}s intentionally |
There was a problem hiding this comment.
... but this means that ResizeObserver sees an irrelevant layout state vs. what we actually intend to render?
There was a problem hiding this comment.
That's correct. It's a tradeoff I think. Either:
- Run before ResizeObserver, then any changes to sizes of content made by ResizeObserver may not be handled by scroll driven animations, but ResizeObserver will see layout driven animation results.
- Run after ResizeObserver, then layout animations may not be fully up to date when calling ResizeObserver, but view timelines will be able to observe resizeobserver derived sizes.
Given that ResizeObservers are designed for establishing the size of elements, I feel like view timelines should be updated to reflect the final resize observer output. The converse, animating layout firing ResizeObservers in response to scroll seems like an anti-pattern.
There was a problem hiding this comment.
We're going to want to use the same mechanism and invalidation for anchor positioning. Chatting with @bfgeek we thought after ResizeObserver would be more in line with the use cases.
added 2 commits
April 25, 2023 21:22
…nce' into scroll-animations-layout-dependence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8694.