Skip to content

[css-display-3] small editorial changes #8740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[css-display-3] small editorial changes #8740

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f072f04
[css-display-3] small editorial changes
TKDev7 Apr 20, 2023
a53a908
switch back to source document in first paragraph
TKDev7 Apr 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions css-display-3/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ Introduction</h2>
(which can contain text),
and renders it onto a <a href="https://www.w3.org/TR/CSS2/intro.html#canvas">canvas</a>
such as your screen, a piece of paper, or an audio stream.
Although any such source document can be rendered with CSS,
Although any such document tree can be rendered with CSS,
Copy link
Collaborator

@fantasai fantasai Apr 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could change this to “element tree”, which is defined in the previous sentence. But we can't change this to “document tree” which would be cross-linking to the DOM specifically, since it's about how element trees don't have to be the DOM...

Copy link
Contributor Author

@TKDev7 TKDev7 Apr 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the most commonly used type is the DOM. Some of these more complex tree types might have additional types of nodes, such as the comment nodes in the DOM

I don’t think DOMs are element trees since they contain comment nodes. i believe they are more of document trees.

This is also the term used in Box Model Module:

CSS describes how each element and each string of text in a source document is laid out by transforming the document tree into a set of boxes, whose size, position, and stacking level on the canvas depend on the values of their CSS properties.

Also Cascading and Inheritance Module:

Once a user agent has parsed a document and constructed a document tree, it must assign, to every element in the tree, and correspondingly to every box in the formatting structure, a value to every property that applies to the target media type.

Also in the CSS 2.1 Specification, Chapter 2 section 2.3:

  1. From the annotated document tree, generate a formatting structure. Often, the formatting structure closely resembles the document tree, but it may also differ significantly, notably when authors make use of pseudo-elements and generated content. First, the formatting structure need not be "tree-shaped" at all -- the nature of the structure depends on the implementation. Second, the formatting structure may contain more or less information than the document tree. For instance, if an element in the document tree has a value of 'none' for the 'display' property, that element will generate nothing in the formatting structure. A list element, on the other hand, may generate more information in the formatting structure: the list element's content and list style information (e.g., a bullet image).

So from my understanding CSS will render document trees, ignoring non-element and non-text nodes.

Copy link
Contributor Author

@TKDev7 TKDev7 Apr 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm the Selectors Module does refer to the DOM as element tree

Selectors are evaluated against an element tree such as the DOM. Within this specification, this may be referred to as the "document tree" or "source document".

Yeah I am just confused now.

Copy link
Collaborator

@fantasai fantasai Apr 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that all needs a bit of clean-up... the term “element tree” didn't have a definition before, so there wasn't anything to anchor the terminology before. :/

I don’t think DOMs are element trees since they contain comment nodes. i believe they are more of document trees.

CSS operates on element trees, fundamentally, and wrt the DOM, it essentially operates on an element-tree projection of the DOM (ignoring comment nodes, etc.). That's the concept that this paragraph is defining.

This sentence specifically is about how you can apply CSS to an element tree that isn't derived from the DOM, so we definitely shouldn't be using the term “document tree” here. We can either leave it as “source document” or change it to “element tree”.

Copy link
Contributor Author

@TKDev7 TKDev7 Apr 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose I will leave it as is and close this PR then.

the most commonly used type is the DOM. [[DOM]]
(Some of these more complex tree types might have additional types of nodes,
such as the comment nodes in the DOM.
Expand Down Expand Up @@ -2234,4 +2234,4 @@ Self-Review Questionnaire: Security and Privacy: Questions to Consider</a>

<li>Does this specification allow downgrading default security characteristics?
<p>No.
</ol>
</ol>