Skip to content

Conversation

@flackr
Copy link
Contributor

@flackr flackr commented Apr 24, 2023

This adds sections explaining the addition of automatically fitting an auto duration to a scroll timeline or view timeline and the introduction of a ranges section to explain animation ranges.

…iner

This adds sections explaining the addition of automatically fitting an
auto duration to a scroll timeline or view timeline and the introduction
of a ranges section to explain animation ranges.
@flackr flackr requested a review from kevers-google April 24, 2023 20:15

#### Exclusive end ranges

In Web Animations, ranges have exclusive ends to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need more clarification. Only one of the boundaries of the active range is exclusive based on the playback rate.

Not clearly stated why it is problematic for ScrollTimelines.

Would the following be clearer:

An exception is made for a ScrollTimeline with an active range that fills the scroll range to avoid the effect from becoming inactive at the scroll boundary. Since unable to scroll past the boundary no special accommodation is needed to facilitate animations intersecting at the boundary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I've updated this section using similar text to what you recommended. Your link didn't seem to work, but I instead linked to the spec section on progress timeline boundary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My link was just a ... placeholder :)

@flackr flackr requested a review from kevers-google April 25, 2023 16:03
Copy link
Contributor

@kevers-google kevers-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flackr flackr merged commit d59c114 into w3c:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants