Skip to content

[scroll-animations-1] Use options dictionary for getCurrentTime() #8201 #8764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2023
Merged

[scroll-animations-1] Use options dictionary for getCurrentTime() #8201 #8764

merged 1 commit into from
Apr 25, 2023

Conversation

fantasai
Copy link
Collaborator

I think there's more to consider here, but this at least aligns us with the most recent resolution in #8201.

@fantasai fantasai requested a review from flackr April 24, 2023 21:43
flackr
flackr approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@flackr flackr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fantasai fantasai merged commit ba53095 into w3c:main Apr 25, 2023
@fantasai fantasai deleted the getCurrentTime branch April 25, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flackr flackr flackr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fantasai @flackr