Skip to content

[css-view-transitions-1][css-viewport] Resolve a few missing types #8901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khushalsagar merged 3 commits into from
Jun 1, 2023
Merged

[css-view-transitions-1][css-viewport] Resolve a few missing types #8901

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a12c26
Update date for publishing
noamr Jun 1, 2023
792989f
Define missing types
noamr Jun 1, 2023
1b896fa
Remove all view-box stuff
noamr Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove all view-box stuff
  • Loading branch information
@noamr
noamr committed Jun 1, 2023
commit 1b896face6361bb94e7dc6c48869117be06109bb
47 changes: 0 additions & 47 deletions css-view-transitions-1/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,9 +852,6 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;
: <dfn>old transform</dfn>
:: a <a data-xref-type="css-type">&lt;transform-function&gt;</a>, initially the [=identity transform function=].

: <dfn>old object-view-box</dfn>
:: Null or a <a data-xref-type="css-type">&lt;basic-shape-rect&gt;</a>, initially none.

: <dfn>old writing-mode</dfn>
:: Null or a 'writing-mode', initially null.

Expand All @@ -877,12 +874,6 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;
: <dfn>group styles rule</dfn>
:: A {{CSSStyleRule}} or null. Initially null.

: <dfn>old view-box rule</dfn>
:: A {{CSSStyleRule}} or null. Initially null.

: <dfn>new view-box rule</dfn>
:: A {{CSSStyleRule}} or null. Initially null.

: <dfn>image pair isolation rule</dfn>
:: A {{CSSStyleRule}} or null. Initially null.

Expand Down Expand Up @@ -1282,11 +1273,6 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;
|element|'s [=border box=] from the [=snapshot containing block origin=] to its
current visual position.

1. Set |capture|'s [=captured element/old object-view-box=] to ''object-view-box/none''
if |element| is the [=document element=], otherwise, to an 'object-view-box' value
that, when applied to the old image, will cause the view box to coincide with
|element|'s [=border box=] in the image.

1. Set |capture|'s [=captured element/old writing-mode] to the [=computed value=] of 'writing-mode' on |element|.

1. Set |capture|'s [=captured element/old direction] to the [=computed value=] of 'direction' on |element|.
Expand Down Expand Up @@ -1364,20 +1350,6 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;

1. Append |old| to |imagePair|.

1. Let |oldViewBox| be |capturedElement|'s [=captured element/old object-view-box=].

1. Set |capturedElement|'s [=captured element/old view-box rule=] to a new {{CSSStyleRule}} representing the following CSS,
and append it to |document|'s [=document/view transition style sheet=].

<!-- deliberately using <pre> so the example can contain <var> references -->
<pre highlight="css">
:root::view-transition-old(<var>transitionName</var>) {
object-view-box: <var>oldViewBox</var>;
}
</pre>

Note: The above code example contains variables to be replaced.

1. If |capturedElement|'s [=new element=] is not null, then:

1. Let |new| be a new ''::view-transition-new()'',
Expand Down Expand Up @@ -1720,25 +1692,6 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;

1. Set |new|'s [=replaced element=] content to the result of [=capturing the image=] of |capturedElement|'s [=new element=].

1. Let |newViewBox| be an ''object-view-box'' value that when applied to |new|,
will cause the view box to coincide with |capturedElement|'s [=new element=]'s [=border box=] in the image.
This must be expressed using ''&lt;basic-shape&gt;/inset()''.

1. If |capturedElement|'s [=captured element/new view-box rule=] is null,
then set |capturedElement|'s [=captured element/new view-box rule=] to a new {{CSSStyleRule}} representing the following CSS,
and append it to |document|'s [=document/view transition style sheet=].

Otherwise, update |capturedElement|'s [=captured element/new view-box rule=] to match the following CSS:

<!-- deliberately using <pre> so the example can contain <var> references -->
<pre highlight="css">
:root::view-transition-new(<var>transitionName</var>) {
object-view-box: <var>newViewBox</var>;
}
</pre>

Note: The above code example contains variables to be replaced.

This algorithm must be executed to update styles in [=user-agent origin=] if its effects can be observed by a web API.

Note: An example of such a web API is `window.getComputedStyle(document.documentElement, "::view-transition")`.
Expand Down