Reorganize Concepts in View Transitions spec #8918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7989a9 to
8c7973c
Compare
khushalsagar
reviewed
Jun 7, 2023
| The [=view transition layer=] is a sibling of this stacking context. | ||
|
|
||
| - The [=view transition layer=] paints after the stacking context for the [=document element=] and [=Document/top layer=]. | ||
| This includes the filters and effects that are applied to the [=document element=]. |
There was a problem hiding this comment.
While we're here. Should the line about filters go to the second point, "this" is ambiguous in the sentence.
"If the ''::view-transition'' pseudo-element exists,
a new [=stacking context=] is created for the [=document element=] and the [=Document/top layer=].
This [=stacking context=] includes the filters and effects that are applied to the [=document element=].
The [=view transition layer=] is a sibling of this stacking context.
There was a problem hiding this comment.
I rewrote this part in #8927 so I think we should leave it untouched here. :)
* Make rules about grouping/flattening due to view-transition-name into a subsection of the property definition. * Expand out the text of the 3D flattening rule, so that it is reasonably self-evident without following the link. * Rename “involved in a view transition” to “captured in a view transition” to better link related concepts by using more closely related terminology. * Move transition suppression impacts under its definition, since these impacts are why that concept exists.
…the algorithms that use them. And pull out Monkey Patches into a top-level section, since they're also effectively interfaces with the world outside this spec.
8c7973c to
274d13b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch splits apart the Concepts section which was a collection of random ideas and consolidates the various parts with related content.
It might be easier to review commit by commit.